Problem/Motivation

I had the older version of the quick_node_clone(8.x-1.16) module and group module(2.2.1). After updating to its latest versions quick_node_clone(8.x-1.17) module and group module(2.2.2) I am encountering the following error 'Error: Class "Drupal\quick_node_clone\Entity\ManageVersionGroup" not found' in several files.I noticed that 'use Drupal\quick_node_clone\ManageVersionGroup;' is missing in the following files:

  • docroot/modules/contrib/quick_node_clone/quick_node_clone.module
  • docroot/modules/contrib/quick_node_clone/src/Entity/QuickNodeCloneEntityFormBuilder.php

but present in the 'docroot/modules/contrib/quick_node_clone/src/Form/QuickNodeCloneNodeForm.php' file.

Steps to reproduce

Update from quick_node_clone(8.x-1.16) module and group module(2.2.1) to quick_node_clone(8.x-1.17) module and group module(2.2.2)

Proposed resolution

Import the classes in the mentioned files.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

enaznin created an issue. See original summary.

enaznin’s picture

Issue summary: View changes
enaznin’s picture

Issue summary: View changes
enaznin’s picture

markdorison’s picture

Status: Active » Needs work

Thank you for the issue and patch! Before review, it needs to be re-rolled as a merge request so that GitLabCI tests will run against it.

enaznin’s picture

Assigned: enaznin » Unassigned

viren18febS made their first commit to this issue’s fork.

viren18febs’s picture

Status: Needs work » Needs review

I have created the MR for same patch, please review.

markdorison’s picture

Status: Needs review » Needs work

PHPCS is flagging these additions because ManageVersionGroup is not used in those changed files.

I noticed that 'use Drupal\quick_node_clone\ManageVersionGroup;' is missing in the following files:

What led you to those specific files as needing the use statements?

himanshu_jhaloya made their first commit to this issue’s fork.

samit.310@gmail.com made their first commit to this issue’s fork.

samit.310@gmail.com changed the visibility of the branch 3415081-error-class-drupalquicknodecloneentitymanageversiongroup to hidden.

samit.310@gmail.com changed the visibility of the branch 3415081-remove-unused to hidden.

samitk’s picture

Status: Needs work » Needs review

This code Drupal\quick_node_clone\Entity\ManageVersionGroup from use statement, is already removed in 8.x-1.18 tag.

markdorison’s picture

Version: 8.x-1.17 » 8.x-1.x-dev
Status: Needs review » Needs work

I am not seeing any changes in the MR 27 diff. Am I missing something?

samitk’s picture

Hi @markdorison,

Actually when i rebase it with new code that changes all the changes was already there. Following are the changes i pushed with 27 MR.

https://git.drupalcode.org/project/quick_node_clone/-/merge_requests/27/...

I guess we can close this ticket as the issue is already resolved.

Thanks
Samit K.

gg24’s picture

Status: Needs work » Closed (outdated)

This issue is not reproducible anymore and the class mentioned is not needed to be imported anymore in the mentioned classes. Hence closing this issue. Feel free to reopen the issue if needed.

Thanks!