Problem/Motivation

\Drupal\Tests\system\Functional\System\SitesDirectoryHardeningTest uses \Drupal\Core\StringTranslation\StringTranslationTrait, but there's no need for it.

Steps to reproduce

Proposed resolution

Remove the trait from the test.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3414994

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !6201

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Simple cleanup.

spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3414655: [META] Convert Functional tests classes which make no HTTP requests into Kernel tests

snap_x changed the visibility of the branch 3414994-sitesdirectoryhardeningtest-does-not to hidden.

snap_x changed the visibility of the branch 3414994-sitesdirectoryhardeningtest-does-not to active.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed b79240e2a9 to 11.x and 896411b2d6 to 10.2.x. Thanks!

  • longwave committed b79240e2 on 11.x 
    Issue #3414994 by Spokje: SitesDirectoryHardeningTest does not need to...

Spokje closed merge request !6201

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.