Problem/Motivation

On the front-page images look blurred.

Steps to reproduce

Install the theme. Go to front-page and see the image.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 Screenshot from 2024-11-13 12-41-21.png137.93 KBsourojeetpaul
#12 Screenshot from 2024-11-13 12-39-32.png1.13 MBsourojeetpaul
#9 Screenshot from 2024-06-06 16-00-29.png258.01 KBsourojeetpaul
#6 Screenshot 2024-05-21 134906.png107.85 KByashaswi18
#6 Screenshot 2024-05-21 134629.png125.63 KByashaswi18
#5 images-after.png90.14 KBbindu r
#5 images-before.png588.5 KBbindu r
#4 Screenshot from 2024-02-28 13-45-04.png355.97 KBtanushree gupta
Screenshot at Jan 16 14-44-42.png1.31 MBshweta__sharma

Issue fork animal_shelter-3414924

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • image-resize Comparechanges, plain diff MR !11
  • 1.0.x Comparecompare
About issue forks

Comments

shweta__sharma created an issue. See original summary.

Tanushree Gupta made their first commit to this issue’s fork.

Tanushree Gupta opened merge request !11

tanushree gupta’s picture

tanushree gupta commented
Status: Active » Needs review
StatusFileSize
new Screenshot from 2024-02-28 13-45-04.png355.97 KB

Corrected css so that the image will not look blur.
https://git.drupalcode.org/project/animal_shelter/-/merge_requests/11
Here is a screenshot.

bindu r’s picture

bindu r commented
StatusFileSize
new images-before.png588.5 KB
new images-after.png90.14 KB

Hi, applied MR 11, which resized the image but i could see the image is still somewhat blur .Attaching the ss for reference.

yashaswi18’s picture

yashaswi18 commented
StatusFileSize
new Screenshot 2024-05-21 134629.png125.63 KB
new Screenshot 2024-05-21 134906.png107.85 KB

Applied MR!11, this is how the image is appearing now. Attaching screenshots. Please check.

sourojeetpaul’s picture

sourojeetpaul commented
Status: Needs review » Needs work
tanushree gupta’s picture

tanushree gupta commented
Status: Needs work » Needs review

Updated the code as mentioned in the comments.
https://git.drupalcode.org/project/animal_shelter/-/merge_requests/11/di...

sourojeetpaul’s picture

sourojeetpaul commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2024-06-06 16-00-29.png258.01 KB

Thanks, @Tanishree Gupta for the quick action.
I can see all the comments have been addressed now. After applying the patch the image is not blurry or pixelated now anymore.
Hence moving it to RTBC++
Attaching screenshot for reference!

sourojeetpaul’s picture

sourojeetpaul commented
Status: Reviewed & tested by the community » Needs work

Hi @tanushree gupta,
Your MR has new merge conflicts now, can you kindly fix those so that I can ship that in?
Hence I've to move it back to NW!

tanushree gupta’s picture

tanushree gupta commented
Status: Needs work » Needs review
sourojeetpaul’s picture

sourojeetpaul commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2024-11-13 12-39-32.png1.13 MB
new Screenshot from 2024-11-13 12-41-21.png137.93 KB

Hi @tanushree gupta,
Thanks for your prompt action and solving the merge conflicts. The issue is getting resolved by the patch. Attaching screenshots for better visibility and moving the issue forward!

sourojeetpaul’s picture

sourojeetpaul commented
Status: Reviewed & tested by the community » Fixed

Thank you all for your time and efforts. The issue is fixed now :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.