Hi there

I want to offer to become a co-maintainer of the module. As you can see from my profile - https://www.drupal.org/u/astonvictor I know how to manage patches/modules/etc.

I want to create a stable release for Drupal 10 and fix all open issues.

thank you in advance

Comments

AstonVictor created an issue. See original summary.

adamps’s picture

Status: Active » Postponed

Great thanks for your enthusiasm. We already have a stable release for Drupal 10. The module is now quite stable, but there are still a few issues open and it would be great to have help fixing them and you could post patches or merge requests.

After you have some specific experience with this module that we can talk about you becoming a co-maintainer. For sure you have an impressive profile on Drupal.org. The challenge for anyone joining the team is that this module contains some code that is very subtle and security-critical. Even though I've developed most of the code, sometimes I have to spend an hour checking all the details of a fix😃.

astonvictor’s picture

Status: Postponed » Needs work
astonvictor’s picture

Status: Needs work » Needs review
adamps’s picture

I took a quick look, great thanks, that's really helpful. I'll look in more detail later when I have more time.

adamps’s picture

Great thanks I really appreciate your support and I would like to have you as a maintainer. I would still like to review the issues please as I think I can spot some extra things from my experience as author of the module. Would you be OK to work like that? You can set me to owner with "Needs review" status then I will set back to "RTBC" when I'm happy for you to commit. I will check roughly once per month. How does that sound??

astonvictor’s picture

It sounds good. I won’t merge any issues until your review.

adamps’s picture

Status: Needs review » Fixed

Thanks should now be done

astonvictor’s picture

thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.