Problem/Motivation

Back when Nightwatch was just introduced into Drupal core, it was probably a good idea to have an example test to show some basic commands/assertions, so core/tests/Drupal/Nightwatch/Tests/exampleTest.js was committed.

However, by now we have enough Nightwatch tests available that cover all commands/assertions that are in core/tests/Drupal/Nightwatch/Tests/exampleTest.js and more.
Running core/tests/Drupal/Nightwatch/Tests/exampleTest.js now just costs time and money.

Steps to reproduce

Proposed resolution

Remove core/tests/Drupal/Nightwatch/Tests/exampleTest.js and its resource core/tests/Drupal/Nightwatch/Pages/TestPage.js.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3414760

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !6173

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Cleanup makes sense.

  • catch committed 6f6f581d on 10.2.x 
    Issue #3414760 by Spokje: Remove Nightwatch exampleTest

  • catch committed 27894c3f on 11.x 
    Issue #3414760 by Spokje: Remove Nightwatch exampleTest
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Good spot, I had no idea this was still there.

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

Spokje closed merge request !6173

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.