Problem/Motivation

From #3108309-29: Support Yaml::PARSE_CUSTOM_TAGS in \Drupal\Component\Serialization\YamlSymfony::decode

Re #27 I was tempted to suggest that. I was reticent because service.yml files are one of the thing parsed on cold cache. But the more I think about it the more I think that this is a good approach for now. The capabilities of the YAML parser and container configuration are quite closely related so this does not feel like a bad decision - also we use FileCache here so potentially this has no impact on cold cache as that can persist across a cache rebuild.

Trying to duplicate custom tag support from upstream Symfony in both the YamlSymfony and YamlPecl serializers is becoming increasingly complex. Let's save ourselves the headache and only use YamlSymfony for service yamls.

Steps to reproduce

Proposed resolution

Only use YamlSymfony for service yamls.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3414647

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

kim.pepper created an issue. See original summary.

kim.pepper’s picture

Status: Active » Needs review
kim.pepper’s picture

Status: Needs review » Postponed
Related issues: +#3205480: Drop PECL YAML library support in favor of only Symfony YAML

Postponing on #3205480: Drop PECL YAML library support in favor of only Symfony YAML as that will make this issue redundant.

andypost’s picture

Status: Postponed » Needs review
wim leers’s picture

#3205480: Drop PECL YAML library support in favor of only Symfony YAML landed, which means this can AFAICT be closed?

andypost’s picture

Status: Needs review » Closed (outdated)

Yes, we should keep serializer configurable via Settings yaml_parser_class

andypost’s picture

@kim.pepper please close MR