Problem/Motivation

\Drupal\Tests\options\Functional\OptionsDynamicValuesApiTest Makes no HTTP requests but is a functional test.

Steps to reproduce

Proposed resolution

Convert \Drupal\Tests\options\Functional\OptionsDynamicValuesApiTest into a Kernel test.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3414501

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Issue tags: +Test suite performance

Spokje opened merge request !6152

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Parent issue: » #3414655: [META] Convert Functional tests classes which make no HTTP requests into Kernel tests
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Reviewed the changes and appears coverage has not be lost.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Reviewed & tested by the community » Needs review

Seeing https://git.drupalcode.org/project/drupal/-/merge_requests/6155#note_254870, I removed the random user_id here as well.
So this needs to go back to NR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Change LGTM.

  • catch committed 79b14beb on 10.2.x 
    Issue #3414501 by Spokje, smustgrave: Convert...

  • catch committed 18125a46 on 11.x 
    Issue #3414501 by Spokje, smustgrave: Convert...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Commited/pushed to 11.x and cherry-picked to 10.2.x, thanks!

Spokje closed merge request !6152

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.