Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
node system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Jan 2024 at 12:58 UTC
Updated:
29 Jan 2024 at 14:59 UTC
Jump to comment: Most recent
Problem/Motivation
\Drupal\Tests\node\Functional\NodeTemplateSuggestionsTest Makes no HTTP requests but is a functional test.
Steps to reproduce
Proposed resolution
Convert \Drupal\Tests\node\Functional\NodeTemplateSuggestionsTest into a Kernel test.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3414499
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3414499-convert-nodetemplatesuggestionstest-into
changes, plain diff MR !6151
Comments
Comment #3
spokjeComment #4
smustgrave commentedCoverage still seems to be there.
So question, should a meta be opened for these?
Comment #5
spokjeIf you want one, I'll create one.IMHO a meta wouldn't add any/much value. There's no plan, no fancy grepping or tooling involved, it's just me going through all FunctionalTests to see if they could easily be KernelTests.
So there will be more of these popping up, if that validates a meta for you/someone, I'll semi-happily create one, but I would see it as a admin-for-the-sake-of-admin thing.
There are indeed too many, opened #3414655: [META] Convert Functional tests classes which make no HTTP requests into Kernel tests
Comment #6
spokjeComment #9
catchCommitted/pushed to 11.x and cherry-picked to 10.2.x, thanks!