Problem/Motivation

Trying to update site to the Drupal 10 and CKEditor 5, but varbase_editor requires old version of anchor_link, which is not working with CKEditor 5.

Proposed resolution

  • Change drupal/anchor_link to ~1.0 || ~3.0 in the composer.josn file.
  • Move ckeditor:ckeditor from dependencies: to install:, to allow for disabling the departed CKEditor 4 - WYSIWYG HTML editor module
  • Add Varbase Editor requirements helper function for standard drupal profiles on the Varbase Project 9.1.x template

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 9.1.1, varbase_editor-9.1.7

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3414362 by impol: Allowed to update Anchor Link to the latest version to work with CKEditor 5
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

impol created an issue. See original summary.

keshavv’s picture

Status: Active » Needs review
rajab natshah’s picture

Got that,
This is a good idea, Yauheni!
We may should do that with all required modules in the Varbase Editor 9.1.x to allow to upgrading to CKEditor 5

rajab natshah’s picture

Title: Allow to update anchor_link to the latest version » Allow to update Anchor Link to the latest version to work with CKEditor 5
Category: Task » Feature request
Issue summary: View changes
Priority: Minor » Normal

  • Rajab Natshah committed c12de864 on 9.1.x authored by impol
    Issue #3414362 by impol: Allow to update Anchor Link to the latest...
rajab natshah’s picture

#3405819: Add the Anchor Link ~3 module and configure the CKEditor 5 Rich editor text format to use it

Add Varbase Editor requirements helper function for standard drupal profiles

Varbase Editor requires the CKEditor5 Anchor Drupal library.

Download it https://github.com/northernco/ckeditor5-anchor-drupal and place it in the
libraries folder (/libraries).
Use the asset-packagist.org method:
Make sure to change repositories for Drupal and assets:

        "repositories": {
          "drupal": {
            "type": "composer",
            "url": "https://packages.drupal.org/8"
          },
          "assets": {
            "type": "composer",
            "url": "https://asset-packagist.org"
          }
        },

Add the following in the root composer.json for the project

        "installer-paths": {
          "docroot/libraries/ckeditor5-anchor-drupal": ["npm-asset/northernco--ckeditor5-anchor-drupal"],

And

        "drupal-libraries": {
          "library-directory": "docroot/libraries",
          "libraries": [
            {"name": "ckeditor5-anchor-drupal", "package": "npm-asset/northernco--ckeditor5-anchor-drupal"}
          ]
        },

No need to add anything else with Varbase Profile

If the project is a Standard Drupal profile is using Varbase Editor, you need to add the following too:
"npm-asset/northernco--ckeditor5-anchor-drupal": "^0.4.0"

rajab natshah’s picture

Moving to add the following directly in Varbase 9.1.x

"npm-asset/northernco--ckeditor5-anchor-drupal": "^0.4.0"

  • Vardot/varbase-project - Add the installer path and drupal libraries directory for the npm-asset/northernco--ckeditor5-anchor-drupal library #204
  • Vardot/platformsh-varbase - Add the installer path and drupal libraries directory for the npm-asset/northernco--ckeditor5-anchor-drupal library #16

Having a soft release for Varbase Editor only for this change.
To help old websites to switch to CKEditor 5, which Updated old Varbase ~9.0.0 to ~9.1.0 composer.josn to Drupal 10

To update the Updating Varbase ~9.0 to Drupal 10

TODO: Add a new section for - Switch from CKEditor 4 to CKEditor 5

#3413371: Plan: Release Varbase 9.1.1

rajab natshah’s picture

Issue summary: View changes

  • Rajab Natshah committed 93770e68 on 9.1.x
    Issue #3414362: Move ckeditor:ckeditor from dependencies: to install:,...
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Issue tags: +varbase-9.1.1, +varbase_editor-9.1.7

By adding the following into the composer.json in the project

    "drupal/anchor_link": "~3.0",
    "npm-asset/northernco--ckeditor5-anchor-drupal": "^0.4.0",

Making sure to have all in #7

Updater/Support are able to switch to CKEditor 5 and uninstall CKEditor 4 in Varbase ~9.1.0 updated sites
After uninstalling, with their filters or config in the Editors or Filter configs

  • ckeditor_media_embed -- OR upgrade
  • ckeditor_paste_filter
  • image_resize_filter
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Next steps

#3414834: Switch default config for Rich editor and Simple editor from CKEditor 4 to CKEditor 5

rajab natshah’s picture

Issue summary: View changes

✅ Released Varbase 9.1.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.