Problem/Motivation

While checking for provider_supported_langs isset is used. Problem is that Lionbridge returns empty array as supported languages. Isset in that case returns TRUE and tries to check if current translation is allowed.

Steps to reproduce

Have a user without supported languages in Lionbridge and try to submit job request. Error will be generated as requested capabilities do not match.

Proposed resolution

Use empty() instead of !isset() as isset based on current api returns TRUE always.

CommentFileSizeAuthor
#2 check_for_empty_supported_langs-3413199-2.patch584 bytesguncha25

Comments

guncha25 created an issue. See original summary.

guncha25’s picture

guncha25 commented
StatusFileSize
new check_for_empty_supported_langs-3413199-2.patch584 bytes

Added fix to resolve the issue.

Juan.OrtizMenchaca’s picture

Juan.OrtizMenchaca commented

Patch planned for future version 2.28, to be released on monday Jan 15th, 2024. The patch removes the validation altogether, as it's not intended to happen within the connector, but rather in Content API, which is part of the Lionbridge Translation Services integration platform. This change not only solves the same issue, but will reduce complexity within the connector implementation

Juan.OrtizMenchaca’s picture

Juan.OrtizMenchaca commented
Status: Active » Fixed

Fixed on version 8x-2.28

Juan.OrtizMenchaca’s picture

Juan.OrtizMenchaca commented
Status: Fixed » Closed (fixed)