Following the completion of #3405485: Fix prettier formating warnings in javascript files we can now investigate the coding standards and prettier formatting in .yml files.
Currently these are ignored from eslint testing by module_filter/-/blob/4.x/.eslintignore

Issue fork module_filter-3412888

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055 opened merge request !40

jonathan1055’s picture

jonathan1055 commented

The MR is good. The .yml formatting is fixed via the downloadable patch on the other gitlab_templates MR. It failed in the final run only because that MR is a work-in-progress and I have not yet figured out how to make the .patch artifact optional (the job failed because there was no generated .patch of fixes, because there was nothing to fix :-)

We need to remove the attempted drupalCI testing, now that the drupalci.yml file has been deleted. @smustgrave as maintainer, you can edit the automated testing for the project and delete the "tested on commit. issue testing default" test. Interesting that we are getting a deprecation warning at 10.2. Maybe do not delete the test until we've fixed that one (on a separate issue)

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review

Ready for review. The MR eslint job passes without ignoring any .yml files now.

jonathan1055’s picture

jonathan1055 commented
Title: Check prettier formatting in .yml files » Fix coding standards and prettier formatting in .yml files
Assigned: jonathan1055 » Unassigned

Updating title

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Changes seem fine to me.

Love seeing all the green.

jonathan1055’s picture

jonathan1055 commented

:-)

I will work on the deprecation problem too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.