Gitlab Templates have recently updated the core settings for the default phpunit job. See gitlab_templates/-/merge_requests/99.

This meant that the Module Filter phpunit job now runs at core 10.2 when it was previously at core 10.1 and this has caused/revealed a problem in the permissions javascript test - see #3412061: Permissions filter test - waitForNoText() also needs waitForText()

We can use a new feature in the template to test against the previous version in addition to the current version, so that we can see the tests pass at 10.1. Also to give a warning (not failure) for the phpunit at 10.2

CommentFileSizeAuthor
#3 Screenshot 2024-01-04 at 09.17.23.png299.9 KBjonathan1055

Issue fork module_filter-3412243

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055 opened merge request !39

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review
StatusFileSize
new Screenshot 2024-01-04 at 09.17.23.png299.9 KB

MR39 ready for review. The overall pipeline now ends with amber warning not red failure. And we can see a green pass for the previous core phpunit job.

new pipeline

  • jonathan1055 committed c33a618a on 4.x 
    Issue #3412243: Add pipeline phpunit job for previous core version
smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

LGTM

jonathan1055’s picture

jonathan1055 commented

Thanks.
After the commit, the branch test failed for both phpunit jobs with

Failed to run installer database tasks: Failed to connect to your database server. The server reports the following message: <em class="placeholder">SQLSTATE[HY000] [2002] Connection refused [Tip: This message normally means that there is no MySQL server running on the system or that you are using an incorrect host name or port number when trying to connect to the server.

I think this is unrelated to the new change.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.