Problem/Motivation

Something else was broken in Drupal 10.1 -- CSS added by AJAX calls is broken, which snowballs into bigger problems including loss of critical site functionality.

Steps to reproduce

Enable Inline All CSS on a Drupal 10.1 site and attempt to edit a block containing a media library widget. Note that the AJAX response is missing data in the `add_css` command.

Proposed resolution

Temporarily, site owners may be able to use this patch to restore functionality, but I would like some experts that worked on the Drupal 10.1 aggregation changes to chime in with recommendations here...

Remaining tasks

TBD

User interface changes

TBD

API changes

TBD

Data model changes

TBD

CommentFileSizeAuthor
#4 3410005-broken-ajax-4.patch6.22 KBluke.leber
another-10.1-breakage.patch767 bytesluke.leber

Issue fork inline_all_css-3410005

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Luke.Leber created an issue. See original summary.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
commented

This looks like the right change to me - there's no harm if an AJAX request adds CSS as files since by definition it's already making the additional http request for the AJAX request itself.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
StatusFileSize
new 3410005-broken-ajax-4.patch6.22 KB

Let's see how the test bot likes this one...

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Status: Active » Needs review
malik.kotob’s picture

malik.kotob commented
Status: Needs review » Reviewed & tested by the community

The code from the latest patch looks sound (at least to me :D), and I can confirm that the code fixes the issues I was previously facing.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented

  • Luke.Leber authored be0528f4 on 1.0.x 
    Issue #3410005 by Luke.Leber, catch, malik.kotob: CSS added by AJAX...
luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Status: Reviewed & tested by the community » Fixed

Thanks for everything here. 1.0.2 coming shortly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.