Problem/Motivation

If you have no page headers to modify then there is the following warning displayed:
Warning: foreach() argument must be of type array|object, null given in Drupal\access_unpublished\Form\SettingsForm->prepareHeadersDisplay()

Proposed resolution

Cast $headers as array to ensure warning is not shown.

CommentFileSizeAuthor
#4 access_unpublished-n3409084-4.patch547 bytesdamienmckenna
#2 3409084.txt417 byteskristiantosney

Comments

kristiantosney created an issue. See original summary.

kristiantosney’s picture

kristiantosney commented
StatusFileSize
new 3409084.txt417 bytes
kristiantosney’s picture

kristiantosney commented
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 8.x-1.5 » 8.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new access_unpublished-n3409084-4.patch547 bytes

Thank you for opening the issue and providing a patch.

Does this work? It skips the foreach() loop if the $headers list is empty.

  • generalredneck committed 2ee26f2b on 8.x-1.x 
    Issue #3409084 by kristiantosney, damienmckenna: Warning when visiting...
generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
Status: Needs review » Fixed

Simple fix. Pushed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.