Disable deprecated DrupalCI tests and enable GitLab CI tests.

Doing this now.

-mike

CommentFileSizeAuthor
#12 IMG_2438.jpeg351.25 KBfjgarlin

Issue fork auto_login_url-3408694

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ultimike created an issue. See original summary.

ultimike opened merge request !14

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Assigned: ultimike » Unassigned

I spent a few hours this morning trying to convert the Auto Login Url module’s tests from DrupalCI to GitLabCI to no avail. The tests pass on my local, but fail on GitLabCI. I’ve made a bunch of tweaks to the tests in my efforts, to no avail. For the life of me I can’t figure out what the issue is. I would love a second set of eyes on this...

-mike

fjgarlin made their first commit to this issue’s fork.

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review

It was due to paths as drupal is installed in a subdirectory. I fixed a few lines regarding URL generation and also some tests to use absolute URLs.

Last pipeline shows all phpunit jobs fully green so the issue might be marked as Needs review now.

  • ultimike committed 97dbc3ea on 2.x 
    Issue #3408694 by ultimike, fjgarlin: Switch to GitLab CI for running...
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Fixed
fjgarlin’s picture

fjgarlin commented

Just fixing credit as sometimes if #6 and #7 happen too close in time credits might be lost (this is a known issue).

I can see that the checkbox was checked when merging the MR (because the message has both of us populated), but it's missing in the final table of credited people.

fjgarlin’s picture

fjgarlin commented

Ok, I was trying to fix it by myself (because I know it's a known issue) but I can't (which also makes sense since I'm not a maintainer).
Sorry for the noise.

@ultimike - just so you know, when the automatic commit message happens too close to the "Fixed" message, the credits might be overwritten. For example, I can see that you tried to credit me here, but the credit is not there (see the table of credits below). This can only be fixed by maintainers.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

Attempting to fix credit :)

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

Hmm - @fjgarlin - I'm one of the co-maintainers - how can I fix this?

-mike

fjgarlin’s picture

fjgarlin commented
StatusFileSize
new IMG_2438.jpeg351.25 KB

I think you fixed it in #10 as the checkbox is persisting now.

Screenshot

So everything looks good I think.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.