Problem/Motivation

It turns out #3320802: Add responsive preview functionality was incomplete.

Updated description:

Per #6,

Direct GET requests like you get when you right-click-and-open-in-new-TAB the "preview link", can never work.

This didn't clarify that it was only about 'regular node preview', not 'node layout preview'.

Proposed resolution:

This implies that we should just not have a "preview link" on the 'regular node preview', only on the 'node layout preview'. So, remove it.

Older description:

The 'preview link' which this module adds to the responsive-preview dropdown in the edit screen, does not work properly.

Steps to reproduce

Click said link. (Or rather: select link and "Open in new tab" -- direct clicking doesn't always show the failure.)

Remaining tasks

Review (once MR is added)

Issue fork lupus_decoupled-3408519

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

roderik created an issue. See original summary.

roderik opened merge request !70

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented

The only build failure is a single error in PHPUnit that will be fixed through #3395669: Make the gitlab-ci pipeline pass.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Issue summary: View changes
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Issue summary: View changes
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs review » Closed (works as designed)

Use is disputed / I didn't test correctly.

(This /node/preview/UUID link that the MR adds, is only useful when the temporary node state is first stored. Therefore

  • Direct GET requests like you get when you right-click-and-open-in-new-TAB the "preview link", can never work.
  • We have to make a POST request first; this already works (by clicking the "preview link") now.
fago’s picture

fago
Primary language German
Location Vienna
commented

I see, thanks for clarifying.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Issue summary: View changes
Status: Closed (works as designed) » Needs work

Reopening, because we should fix regular node preview, per "updated description".

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs work » Needs review

Pipeline only failing for the one PHPUnit error that is fixed in #3409409: Respect installations with base paths.

  • fago committed 3bcd4877 on 1.x authored by roderik 
    Issue #3408519 by roderik: Remove additional preview link from edit node...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

reviewed + tested, all good now! Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.