Problem/Motivation

My expectations for this module were that each selected role could get their own custom toolbar menu. But after using it, it appears that just 1 extra custom toolbar can be assigned to some role(s).

Is this correct?
Thank you for the module, it makes Gin more close to a dashboard application.

Comments

goose2000 created an issue. See original summary.

jmauricio’s picture

Assigned: Unassigned » jmauricio
Status: Active » Needs work

At the moment its only for one role, but it shouldn't be too hard to make it work for multiple roles/menus. i'm going to work on this as soon as i have some free time

goose2000’s picture

@jmauricio - that would be cool, super useful. Thanks.

  • jmauricio committed a73a9d35 on 1.0.x
    Issue #3406519 by goose2000, jmauricio: Only 1 custom menu ?
    
jmauricio’s picture

Status: Needs work » Fixed

@goose2000

This feature is now available on 1.0.2

jmauricio’s picture

Status: Fixed » Closed (fixed)
goose2000’s picture

This is really great, thank you a lot @jmauricio. Trying later today.

ady1503’s picture

Hello.

I think the problem persists.

When I saving the menu and role configuration, only the last menu of the configuration is visible in the menu bar.

Let me explain better: I go to the configuration page and add the menu first, the roles that should see them,
then I choose the second menu and the roles. But when I log in with a user that I gave permission to see both
menus in the bar, only the last menu is seen, the first is not seen.

I tried adding more menus and only the last one is always seen.

This is the first problem I saw.

Second:

And I also saw that the configuration affects the admin tool bar.
And that the bar is seen in other themes, not only in the gin admin theme as it should be.
For this reason it is called: Gin Toolbar Custom Menu.
It should affect only the "Gin" management theme.

Versión de Drupal
10.3.9
PHP
Versión
8.3.13

Thank you.

jmauricio’s picture

Version: 1.0.1 » 1.0.3
Status: Closed (fixed) » Needs work

@ady1503

The configuration was implemented for one menu per role(s) and not multiple menus per role, but i will look into that, what do you expect? both menu entries joined together?

The second problem i'll have to check, as soon as i have some time.

ady1503’s picture

Hello.

I understand that it is a job to do, I don't expect anything specific. The module is fine as long as you only need one menu and the same roles that have access. But it would be interesting to at least have the possibility of having more menus in the toolbar. The idea in itself is very good that the Gin theme has the possibility of activating menus with links.

I will use the existing functionality, but it is limited, and this means that many people do not use the module.

Gracias

  • jmauricio committed d0a42570 on 1.0.x
    Issue #3406519 by goose2000, jmauricio: Only 1 custom menu ?
    
jmauricio’s picture

Component: Documentation » Code
Assigned: jmauricio » Unassigned
Category: Support request » Feature request
Status: Needs work » Needs review

@ady1503

Just pushed a fix into 1.0.x that adds the ability for multiple menus per role.

As far as the second problem you describe, i can't replicate it, are you using the latest version?

ady1503’s picture

Hello.

What I mean is, if it is applied to the admin role then it modifies the bar completely, with the chosen menus, and the others disappear. It doesn't have much importance, it was for information.

Thank you.

ady1503’s picture

I have tested the latest changes you made, everything works fine.
As I said above, if the administrator or authenticated role is chosen,
the entire bar is affected, with the chosen menus, and the default ones disappear.

It is not a bug as such, I am just reporting it so that users know.

Thanks for the module.

jmauricio’s picture

Status: Needs review » Fixed

Released version 1.0.4

jmauricio’s picture

Status: Fixed » Closed (fixed)