Closed (fixed)
Project:
Drupal core
Version:
10.2.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Dec 2023 at 01:25 UTC
Updated:
23 Feb 2024 at 18:29 UTC
Jump to comment: Most recent
cspell identifies the use of 'milli' in this sentence as a misspelling.
* (due to limitations of jQuery.serialize()). That is deemed to be
* acceptable, because if the user forgot to attach a file, then the size of
* HTTP payload will most likely be small enough to be fully passed to the
* server endpoint within {milli}seconds. If a user mistakenly attached a
* wrong file and is technically versed enough to cancel the form submission
* (and HTTP payload) in order to attach a different file, then that
* edge-case is not supported here.The use of milli first appeared in the patch at #1705618-21: Double click prevention on form submission and was in commit 502e953.
In #3397490: Fix more words that are only misspelled in comments xjm suggested "the author meant to say something like"
* server endpoint within seconds, or even milliseconds. If a user
* mistakenly attached a wrong file and is technically versed enough to
* cancel the form submission (and HTTP payload) in order to attach a
* different file, then that edge-case is not supported here.Determine the correct change so milli is not detected as a spelling error and the comment is correct.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
drupaler_kushal commentedCompleted the text change in the comment. Added it in correct way. Please review here https://git.drupalcode.org/project/drupal/-/merge_requests/6283
Comment #5
smustgrave commented@quietone should we try and remove milli from cspell.
Comment #6
quietone commented@Drupaler_Kushal, thanks for making this change. However, the lines need to be wrapped at 80 columns. This to meet the Line length and wrapping Drupal coding standard.
I am setting this back to Needs Work.
Comment #9
drupaler_kushal commentedOk @quietone, let me check.
Comment #10
drupaler_kushal commentedUpdated the code as per suggestion and standard, please review.
Comment #11
smustgrave commentedBelieve the goal was to be able to remove milli from the dictionary. That’s still there.
Comment #12
lenenba commentedI am working on this issue now as part of a novice contribution workshop at Symetris
Comment #13
lenenba commentedComment #14
smustgrave commentedlgtm
Comment #15
quietone commentedThanks everyone for working on this issue!
I have left a comment in the MR.
Comment #16
karimb commentedComment #17
smustgrave commentedabbreviations are removed.
Comment #20
longwaveCommitted and pushed to 11.x, and backported to 10.2.x to keep the dictionary in sync as this only affects a comment. Thanks!