Problem/Motivation

cspell identifies the use of 'milli' in this sentence as a misspelling.

   *   (due to limitations of jQuery.serialize()). That is deemed to be
   *   acceptable, because if the user forgot to attach a file, then the size of
   *   HTTP payload will most likely be small enough to be fully passed to the
   *   server endpoint within {milli}seconds. If a user mistakenly attached a
   *   wrong file and is technically versed enough to cancel the form submission
   *   (and HTTP payload) in order to attach a different file, then that
   *   edge-case is not supported here.

The use of milli first appeared in the patch at #1705618-21: Double click prevention on form submission and was in commit 502e953.

Steps to reproduce

Proposed resolution

In #3397490: Fix more words that are only misspelled in comments xjm suggested "the author meant to say something like"

   *   server endpoint within seconds, or even milliseconds. If a user
   *   mistakenly attached a wrong file and is technically versed enough to
   *   cancel the form submission (and HTTP payload) in order to attach a
   *   different file, then that edge-case is not supported here.

Remaining tasks

Determine the correct change so milli is not detected as a spelling error and the comment is correct.

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3406109

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

Drupaler_Kushal made their first commit to this issue’s fork.

drupaler_kushal’s picture

Status: Active » Needs review

Completed the text change in the comment. Added it in correct way. Please review here https://git.drupalcode.org/project/drupal/-/merge_requests/6283

smustgrave’s picture

Issue tags: +Novice

@quietone should we try and remove milli from cspell.

quietone’s picture

Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +cspell error

@Drupaler_Kushal, thanks for making this change. However, the lines need to be wrapped at 80 columns. This to meet the Line length and wrapping Drupal coding standard.

I am setting this back to Needs Work.

KarimB changed the visibility of the branch 3406109-correct-milli-in to hidden.

KarimB changed the visibility of the branch 3406109-correct-milli-in to active.

drupaler_kushal’s picture

Ok @quietone, let me check.

drupaler_kushal’s picture

Status: Needs work » Needs review

Updated the code as per suggestion and standard, please review.

smustgrave’s picture

Status: Needs review » Needs work

Believe the goal was to be able to remove milli from the dictionary. That’s still there.

lenenba’s picture

I am working on this issue now as part of a novice contribution workshop at Symetris

lenenba’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

lgtm

quietone’s picture

Status: Reviewed & tested by the community » Needs work

Thanks everyone for working on this issue!

I have left a comment in the MR.

karimb’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

abbreviations are removed.

  • longwave committed ec59a5fe on 10.2.x
    Issue #3406109 by Drupaler_Kushal, KarimB, Lenenba, smustgrave, quietone...

  • longwave committed 03bdedd3 on 11.x
    Issue #3406109 by Drupaler_Kushal, KarimB, Lenenba, smustgrave, quietone...
longwave’s picture

Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 11.x, and backported to 10.2.x to keep the dictionary in sync as this only affects a comment. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.