Problem/Motivation

Steps to reproduce

Admin > Config > Content Authoring > Entity Usage Light settings, check only content entity
Go to a user edit form -> the usage tab is here

Proposed resolution

Check if current entity is in active in config before add tab.

CommentFileSizeAuthor
#8 Afterpatch-user.png13.26 KBkanchan bhogade
#8 Afterpatch-content.png15.94 KBkanchan bhogade
#8 beforepatch-user.png15.7 KBkanchan bhogade
#8 Beforepatch-content.png11.28 KBkanchan bhogade
#8 Entity-Usage-Light-settings-D10.png83.45 KBkanchan bhogade
#2 3405825-fix-display-tab-condition.patch795 bytesdaisyleroy

Issue fork entity_usage_light-3405825

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

daisyleroy created an issue. See original summary.

daisyleroy’s picture

daisyleroy commented
StatusFileSize
new 3405825-fix-display-tab-condition.patch795 bytes
daisyleroy’s picture

daisyleroy commented
Status: Active » Needs review
daisyleroy’s picture

daisyleroy commented
Assigned: daisyleroy » Unassigned
ericdsd’s picture

ericdsd commented

Tested patch #2 it works like a charm
+1 for RTBC

kanchan bhogade’s picture

kanchan bhogade commented
Status: Needs review » Needs work

Hi @ericdsd
I've tried to reproduce the issue, but from the issue summary not got the exact issue and expected behavior of the module,
Can you please add more details around it, it will be helpful to work on it.

Thank you

kanchan bhogade’s picture

kanchan bhogade commented
Status: Needs work » Needs review

Hi,
got the issue, moving to Needs Review

kanchan bhogade’s picture

kanchan bhogade commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Entity-Usage-Light-settings-D10.png83.45 KB
new Beforepatch-content.png11.28 KB
new beforepatch-user.png15.7 KB
new Afterpatch-content.png15.94 KB
new Afterpatch-user.png13.26 KB

Hi
I've tested the #2 patch on Drupal version 10.x
The patch was applied successfully...

Testing steps:

  1. Admin > Config > Content Authoring > Entity Usage Light settings, check only content entity
  2. Go to a user edit form -> the usage tab is here

Test Result:
Only activate the content entity type's entity/node having a Usage tab.

Adding screenshots for reference

RTBC +1

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !4

smustgrave’s picture

smustgrave commented

Can confirm the bug and that #2 solves the problem.

Turned to MR to hopefully help maintainer.

smustgrave closed merge request !4

  • smustgrave committed 2aff5ec7 on 1.0.x 
    Issue #3405825 by daisyleroy, Kanchan Bhogade: Usage tab is added for...
smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.