Problem/Motivation

PHPCS and PHPStan are reporting issues but not failing the GitLab CI builds.

Proposed resolution

Configure GitLab CI to fail on PHPCS or PHPStan failure and resolve the outstanding issues.

Issue fork csv_serialization-3405366

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

markdorison created an issue. See original summary.

markdorison opened merge request !31

markdorison’s picture

markdorison
he/him
commented
Status: Active » Needs work
markdorison’s picture

markdorison
he/him
commented
Related issues: +#3402274: Call to deprecated method setNewline()
markdorison’s picture

markdorison
he/him
commented
Status: Needs work » Needs review

  • markdorison committed 48b072aa on 4.x 
    Issue #3405366: Resolve issues reported by PHPCS, PHPStan
markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Fixed

markdorison opened merge request !32

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.