Problem/Motivation

https://git.drupalcode.org/project/la_eu/-/jobs/411474

Issue fork la_eu-3405133

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sanduhrs created an issue. See original summary.

kraut’s picture

kraut commented

FYI @volkerk changed pipes to show warnings instead of failing:
https://git.drupalcode.org/project/la_eu/-/jobs/412661

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented

PHPCS is using the wrong the standards and checking the wrong files.

Is it possible to reuse already implemented jobs?
See https://git.drupalcode.org/project/gitlab_templates/-/blob/1.0.x/include...

kraut credited volkerk.

kraut’s picture

kraut commented
Assigned: Unassigned » volkerk

That is the long term goal and talked with Volker to Wim and Nick about that.
But currently they aren't implemented as reusable and consumable blocks.
For now please describe what standards and paths are wrong for Volker to fix :)

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented

The PHPCS ruleset can be found here:
https://git.drupalcode.org/project/gitlab_templates/-/blob/1.0.x/scripts...

The standard is Drupal
Depends on coder module obviously.

Filename extension to check
php,inc,module,install,info,test,profile,theme

For JS and CSS there are different tools available.

volkerk opened merge request !6

volkerk’s picture

volkerk commented
Status: Active » Needs review

Added phpcs.xml.dist, required drupal/coder.
This pipeline shows cs errors: https://git.drupalcode.org/project/la_eu/-/pipelines/60120
In this pipeline cs errors are fixed: https://git.drupalcode.org/project/la_eu/-/pipelines/60122

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me! I don't think this will cause any conflict with the other MR's.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks all! 🤩

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.