Problem/Motivation

Drupal 10.2.0-rc1 is due this week, a number of javascript dependencies have major, minor and patch level release bumps that we should try to incorporate in the release.

Steps to reproduce

$ yarn outdated

Package                 Current Wanted Latest    Package Type          
eslint                  8.53.0  8.54.0 8.54.0    devDependencies       
eslint-formatter-gitlab 5.0.0   5.1.0  5.1.0     devDependencies       
glob                    10.3.5  10.3.5 10.3.10   devDependencies       
jackspeak               2.1.1   2.1.1  2.3.6     resolutionDependencies
jsdom                   22.1.0  22.1.0 23.0.0    devDependencies       
loadjs                  4.2.0   4.2.0  4.3.0-rc1 devDependencies       
nightwatch              2.4.2   2.4.2  3.3.2     devDependencies       
prettier                3.0.3   3.1.0  3.1.0     devDependencies       
shepherd.js             10.0.1  10.0.1 11.2.0    devDependencies

Proposed resolution

Not entirely sure about the rules on major-bumping a JS-dependency in an RC, but since jsdom is only use as a build tool and only for getting (CKEditor5) ESM packages working with Nightwatch I think it's OK? 

$ yarn add -D jsdom
$ yarn upgrade eslint eslint-formatter-gitlab prettier
$ yarn prettier

That leaves us with:

$ yarn outdated
Package     Current Wanted Latest    Package Type          
glob        10.3.5  10.3.5 10.3.10   devDependencies       
jackspeak   2.1.1   2.1.1  2.3.6     resolutionDependencies
loadjs      4.2.0   4.2.0  4.3.0-rc1 devDependencies       
nightwatch  2.4.2   2.4.2  3.3.2     devDependencies       
shepherd.js 10.0.1  10.0.1 11.2.0    devDependencies

Reasons for not updating those are in the parent IS.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3404847

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !5581

spokje’s picture

spokje
Primary language Dutch
commented 
$ yarn-lock-diff -o yarn.old.lock -n yarn.lock
┌──────────────────────────────┬────────────────┬────────────────┐
│ package name                 │ old version(s) │ new version(s) │
├──────────────────────────────┼────────────────┼────────────────┤
│ @eslint/js                   │ 8.53.0         │ 8.54.0         │
├──────────────────────────────┼────────────────┼────────────────┤
│ @tootallnate/once            │ 2.0.0          │ -              │
├──────────────────────────────┼────────────────┼────────────────┤
│ abab                         │ 2.0.6          │ -              │
├──────────────────────────────┼────────────────┼────────────────┤
│ agent-base                   │ 6.0.2          │ 7.1.0          │
├──────────────────────────────┼────────────────┼────────────────┤
│ data-urls                    │ 4.0.0          │ 5.0.0          │
├──────────────────────────────┼────────────────┼────────────────┤
│ domexception                 │ 4.0.0          │ -              │
├──────────────────────────────┼────────────────┼────────────────┤
│ eslint-formatter-gitlab      │ 5.0.0          │ 5.1.0          │
├──────────────────────────────┼────────────────┼────────────────┤
│ eslint                       │ 8.53.0         │ 8.54.0         │
├──────────────────────────────┼────────────────┼────────────────┤
│ flat-cache                   │ [...]          │ [..., 3.2.0]   │
├──────────────────────────────┼────────────────┼────────────────┤
│ html-encoding-sniffer        │ 3.0.0          │ 4.0.0          │
├──────────────────────────────┼────────────────┼────────────────┤
│ http-proxy-agent             │ 5.0.0          │ 7.0.0          │
├──────────────────────────────┼────────────────┼────────────────┤
│ https-proxy-agent            │ 5.0.1          │ 7.0.2          │
├──────────────────────────────┼────────────────┼────────────────┤
│ ignore                       │ [...]          │ [..., 5.3.0]   │
├──────────────────────────────┼────────────────┼────────────────┤
│ jsdom                        │ 22.1.0         │ 23.0.0         │
├──────────────────────────────┼────────────────┼────────────────┤
│ prettier                     │ 3.0.3          │ 3.1.0          │
├──────────────────────────────┼────────────────┼────────────────┤
│ tr46                         │ 4.1.1          │ 5.0.0          │
├──────────────────────────────┼────────────────┼────────────────┤
│ w3c-xmlserializer            │ 4.0.0          │ 5.0.0          │
├──────────────────────────────┼────────────────┼────────────────┤
│ whatwg-encoding              │ 2.0.0          │ 3.1.1          │
├──────────────────────────────┼────────────────┼────────────────┤
│ whatwg-mimetype              │ 3.0.0          │ 4.0.0          │
├──────────────────────────────┼────────────────┼────────────────┤
│ whatwg-url                   │ 12.0.1         │ 14.0.0         │
├──────────────────────────────┼────────────────┼────────────────┤
│ xml-name-validator           │ 4.0.0          │ 5.0.0          │
└──────────────────────────────┴────────────────┴────────────────┘
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

LGTM, didn't break anything from what I can tell by applying locally and just clicking around a standard install.

  • lauriii committed 0ce88f3f on 11.x 
    Issue #3404847 by Spokje: Update JavaScript dependencies for 10.2.0-RC

  • lauriii committed 6e90c4da on 10.2.x 
    Issue #3404847 by Spokje: Update JavaScript dependencies for 10.2.0-RC...

lauriii closed merge request !5581

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +10.2.0 release notes

Committed 0ce88f3 and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.