Problem/Motivation

A PHP notice is being thrown when comparing name fields using Diff.

Steps to reproduce

Add a Name field to a content type, create a node with that content type and multiple revisions, compare the revisions using the Diff module.

Proposed resolution

Fix the Name field plugin for Diff.

Issue fork name-3404704

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

john.oltman created an issue. See original summary.

john.oltman opened merge request !16

john.oltman’s picture

john.oltman commented
Status: Active » Needs review

Opened merge request and needs review. This patch is available from the MR for those who prefer applying a patch over downloading a fork:

https://git.drupalcode.org/project/name/-/merge_requests/16.diff

This is a one liner and obvious so should be a quick review.

maxilein’s picture

maxilein commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3362609: Missing field config for User entity causes PHP errors

I can confirm it works with 8.x-1.0-rc6.
Please add it to the next dev.

heddn made their first commit to this issue’s fork.

  • heddn committed f726735e on 8.x-1.x authored by john.oltman 
    Issue #3404704 by john.oltman, maxilein, heddn: Warning: Undefined array...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Thxs for the contributions.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.