Closed (fixed)
Project:
Lupus Decoupled Drupal
Version:
1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Nov 2023 at 15:22 UTC
Updated:
12 Dec 2023 at 11:44 UTC
Jump to comment: Most recent
Comments
Comment #3
arthur_lorenz commentedComment #4
roderikI don't know if I should set Needs Work, Needs more info or just test it myself (not sure about my allocated time anymore).
I guess I'll rely on an actual module maintainer to do whatever.
Comment #5
arthur_lorenz commentedIn the end both roles are just some config. If the config was not yet applied, the roles won't exist. But I should add the user module as dependency.
don't be :) Usually this should only occur during site install with existing config. Then the permission should be applied in the config files and imported later on. Otherwise the roles should already exist. If not there might be a reason for it and it should not fail.
But I'm wondering if it makes more sense to check the `$is_syncing` and skip the step if it's true to not mess with any config.
Comment #6
roderikRight. Thank you for clarifying :-) I should have kept $is_syncing in mind.
The explanation + the scope of the change (only when $is_syncing, which previously had an error) enables to RTBC after just reviewing code.
Comment #9
fagoMerged, thank you!