Problem/Motivation

Follow up from https://www.drupal.org/project/navigation/issues/3392361#comment-15290559

Default values for variables like --color-focus or --space-xl may be defined in themes so toolbar styles can be easily broken.

Proposed resolution

Define a pattern to name default variables. Discuss its pros and coins.

Issue fork navigation-3403392

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

finnsky created an issue. See original summary.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Title: Toolbar variables default values. » Toolbar variables default values
Issue summary: View changes

I would go with prepending "drupal-admin" to all variables. So we would end up with things like --drupal-admin-color-focus.

kostyashupenko made their first commit to this issue’s fork.

kostyashupenko opened merge request !138

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Needs review
finnsky’s picture

finnsky commented
Status: Needs review » Reviewed & tested by the community

Thank you!

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Needs work

It looks like this needs a manual rebase :)

finnsky’s picture

finnsky commented
Status: Needs work » Needs review

Rebased

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Fixed

Merged! Thanks both!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.