Problem/Motivation

  • Add a BDD test suite that shares an OpenStack Image with projects.

Issue fork cloud-3403261

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !2110

sekinet’s picture

sekinet commented
Status: Active » Needs review

@yas

Could you please review the patch?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@sekinet

Thank you for the patch. I posted my minor comments. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes

@sekinet

Also, please fix the following git error:

2110.diff:54: trailing whitespace.
(function(){const t=document.createElement("link").relList;if(t&&t.supports&&t.supports("modulepreload"))return;for(const i of document.querySelectorAll('link[rel="modulepreload"]'))a(i);new MutationObserver(i=>{for(const o of i)if(o.type==="childList")for(const s of o.addedNodes)s.tagName==="LINK"&&s.rel==="modulepreload"&&a(s)}).observe(document,{childList:!0,subtree:!0});function n(i){const o={};return i.integrity&&(o.integrity=i.integrity),i.referrerpolicy&&(o.referrerPolicy=i.referrerpolicy),i.crossorigin==="use-credentials"?o.credentials="include":i.crossorigin==="anonymous"?o.credentials="omit":o.credentials="same-origin",o}function a(i){if(i.ep)return;i.ep=!0;const o=n(i);fetch(i.href,o)}})();Drupal.t("$");Drupal.t("%");Drupal.t("%action was applied to @count item.");Drupal.t("%action was applied to @count items.");Drupal.t(", ");Drupal.t("- All -");Drupal.t("- Any -");Drupal.t("- None -");Drupal.t("1 Day");Drupal.t("1 Hour");Drupal.t("1 Minute");Drupal.t("1 Week");Drupal.t("1 Year");Drupal.t("1 day");Drupal.t("1 item");Drupal.t("1 week");Drupal.t("1");Drupal.t(`16-32 Characters, e.g. 12ABCDEFGHIJKVWXYZ89 .  If <em>Assume Role</em> 
warning: 1 line adds whitespace errors.
sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas

Thank you for your comments. I have fixed them, so could you please check them?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add a BDD test suite for OpenStack Image (Share to projects) » Add a BDD test suite for OpenStack Image (Share OpenStack projects)
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the update. I ran the BDD tests for the Drupal normal version and SPA; and they have been passed successfully. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed c73443d4 on 6.x authored by sekinet 
    Issue #3403261 by sekinet, yas: Add a BDD test suite for OpenStack Image...

  • yas committed 0d82b16f on 5.x authored by sekinet 
    Issue #3403261 by sekinet, yas: Add a BDD test suite for OpenStack Image...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add a BDD test suite for OpenStack Image (Share OpenStack projects) » Add a BDD test suite for OpenStack Image (Share with OpenStack projects)
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.