Problem/Motivation

Latest run (as of issue creation) on the 1.x-dev branch.

------ ----------------------------------------------------------------- 
  Line   src/OrangeDamMigrationDataManager.php                            
 ------ ----------------------------------------------------------------- 
  128    Call to deprecated method setTrackLastImported() of class        
         Drupal\migrate\Plugin\MigrationInterface:                        
         in drupal:10.1.0 and is removed from drupal:11.0.0. There is no  
         replacement.                                                     
 ------ ----------------------------------------------------------------- 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Derivative/OrangeDamMigrationQueues.php                            
 ------ ------------------------------------------------------------------------------ 
  38     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/QueueWorker/OrangeDamDeletionQueueWorker.php                       
 ------ ------------------------------------------------------------------------------ 
  40     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/migrate/process/OrangeDamProcessBase.php                           
 ------ ------------------------------------------------------------------------------ 
  45     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------- 
  Line   orange_dam.install                                                 
 ------ ------------------------------------------------------------------- 
  14     Variable $contentTypes in empty() always exists and is not falsy.  
  35     Variable $contentTypes in empty() always exists and is not falsy.  
 ------ -------------------------------------------------------------------

Proposed resolution

Resolve PHPStan issues.

Issue fork orange_dam-3403170

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

markdorison created an issue. See original summary.

markdorison’s picture

Status: Active » Needs work
markdorison’s picture

Issue summary: View changes
markdorison’s picture

Status: Needs work » Needs review
StatusFileSize
new194.3 KB

Screenshot of PHPStan passing

PHPStan is now passing with no errors.

adamzimmermann’s picture

Status: Needs review » Reviewed & tested by the community

markdorison’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.