Problem/Motivation

  • Fix an issue where OpenStack Subnet could not be updated and deleted (cloud/dashboard).

Issue fork cloud-3402708

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !2108

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix an issue where OpenStack Subnet could not be updated and deleted (cloud/dashboard) » Fix an issue to update and delete OpenStack Subnet (cloud/dashboard)
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the fix. I posted my comment. Thanks!

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Please check my comment on GitLab. Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I pushed a new commit. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. I think the following test code should be changed, too:

https://git.drupalcode.org/project/cloud/-/blob/6.x/modules/cloud_servic...

There might be more to make sure. Can you please run the BDD tests and validate your code change? Thanks!

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I pushed a commit for the fix and verified that it passes the BDD test. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. I ran the BDD tests for normal Drupal version and SPA version, and both were successful. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed e7b2bc8e on 6.x authored by Ryo Yamashita 
    Issue #3402708 by Ryo Yamashita, yas: Fix an issue to update and delete...

  • yas committed aff9fa18 on 5.x authored by Ryo Yamashita 
    Issue #3402708 by Ryo Yamashita, yas: Fix an issue to update and delete...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.