Problem/Motivation

I'm trying to merge D10 support into the 1.0.x branch. However, the GitLab CI pipelines are now failing over there:

https://git.drupalcode.org/project/entitygroupfield/-/pipelines/50342

Unable to create pipeline
'phpstan' job needs 'composer' job, but 'composer' is not in any previous stage
'stylelint' job needs 'composer' job, but 'composer' is not in any previous stage
'eslint' job needs 'composer' job, but 'composer' is not in any previous stage

Steps to reproduce

Proposed resolution

Fix .gitlab-ci.yml on both branches to make it easy to test across multiple core versions, confirm the matrix testing in 2.0.x is still working how we want, and ensure tests are passing on both branches.

Remaining tasks

  1. Revisit how GitLab CI is configured on all branches.
  2. See if there's now a cleaner way to handle the matrix testing we want/need (in 2.0.x).
  3. See if we can go back to relying on the upstream defaults (in 1.0.x) to better handle what core versions we're testing with.
  4. Confirm all pipeline steps and tests are passing everywhere.

User interface changes

API changes

Data model changes

Issue fork entitygroupfield-3401957

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dww created an issue. See original summary.

dww opened merge request !20

  • dww committed c3a4cd1a on 1.0.x 
    task: [#3401957] Reconfigure GitLab matrix testing for core versions 8.9...

dww opened merge request !21

dww closed merge request !20

  • dww committed 4ec35d32 on 2.0.x 
    task: [#3401957] Reconfigure GitLab matrix testing for 2.0.x branch:

-...

dww closed merge request !21

dww’s picture

dww
we/he/they
commented
Status: Active » Fixed

At last! 😅 It's finally doing what I want. 🎉

When the "canary" build or test fails, none of the matrix builds start:

https://git.drupalcode.org/project/entitygroupfield/-/pipelines/646232

When it all works, it all works in the right order:

https://git.drupalcode.org/project/entitygroupfield/-/pipelines/646237

Phew!

In the process, I fixed GroupAutocompleteFormElementTest to work with group *.3.x branches. See ee349a4f.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dww opened merge request !22

  • dww committed 03666629 on 2.0.x 
    task: [#3401957] Make some of the matrix build jobs manual only...

dww closed merge request !22

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.