After we marked the Announcements Feed stable in #3356488: Mark Announcements Feed as stable, a next step could be to add it to the standard profile.
When installing Drupal with the standard installation profile, the Announcements Feed module get's enabled.
Merge request
None, besides what the module adds.
The standard Drupal Core installation profile now enabled the Announcements Feed module when installing a new site.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !5403
Comments
Comment #3
bramdriesenComment #4
bramdriesenNot sure if this needs a CR 🙂 Actually should look up what the "policy" is for when a issue needs one.
Comment #5
catchWe should definitely do this - we want it enabled when people install, so they can see the feed from the start.
Probably in a separate issue because it'll need Umami maintainer feedback, but I think we should add it there too.
Comment #6
bramdriesenI'll create another child issue.
Comment #7
bramdriesenComment #8
smustgrave commentedWould agree with the permission mentioned. Would imagine admins will want to vet the info coming from the announcement and decide if they want to share with editors. If editors see something about a security release it may alarm them as they don't know better.
Comment #9
bramdriesenComment #10
smustgrave commentedLGTM!
Comment #11
xjmNeeds to be postponed as this is not actionable until the thing is actually marked stable. (I would also be unopposed to simply merging this and the Umami issue into the "mark it stable" issue given the small and related scopes in all three, but what they aren't is committable before it being marked stable).
There's also no architecture to review for this, so it essentially just needs product signoff to confirm that it is a part of the D10 standard core product, basically.
Comment #12
bramdriesenSetting back to RTBC as #3356488: Mark Announcements Feed as stable got merged!
Comment #16
lauriiiCommitted a6e0ce8 and pushed to 11.x. Thanks!
Comment #17
gábor hojtsy