Problem/Motivation

GitLab CI reports the following:

Unable to create pipeline

  • 'phpstan' job needs 'composer' job, but 'composer' is not in any previous stage
  • 'eslint' job needs 'composer' job, but 'composer' is not in any previous stage

Steps to reproduce

On a Smart Trim issue, open a MR. GitLab CI will fail to run.

Proposed resolution

Update GitLab CI to best practcle.

Remaining tasks

Update .gitlab-ci.yml with best practice template.

Issue fork smart_trim-3401469

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lostcarpark created an issue. See original summary.

lostcarpark opened merge request !74

lostcarpark’s picture

lostcarpark commented

We have a bit of a chicken and egg situation.

Pipeline is now passing, apart from a PHPStan warning about new static, which #3401014: PHPStan reporting "Unsafe use of new static()" will fix. But the pipelines on that issue can't run without this change.

Can this be merged so it can be rebased into #3401014: PHPStan reporting "Unsafe use of new static()"?

lostcarpark’s picture

lostcarpark commented
Status: Active » Needs review
lostcarpark’s picture

lostcarpark commented

And thanks to @ultimike for working out a more best-practice way of using the GitLab CI!

ultimike made their first commit to this issue’s fork.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Fixed

Thanks, James!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.