Problem/Motivation

Fixing some linting issues with Gitlab CI

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork simplesamlphp_auth-3401289

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mikelutz created an issue. See original summary.

mikelutz opened merge request !27

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

did you meant to create this against 8.x-3.x?

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented

Nope, didn't realize that was still the default branch. I'm working on it. :-)

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Active » Needs review

@berdir IF you are interested in doing this, I think I flagged the non-obvious fixes that need maintainer eyes.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Version: 4.0.0 » 4.x-dev
nikolay shapovalov’s picture

nikolay shapovalov commented

It looks like changes made in this issue is very similar to #3382137: Fix the issues reported by phpcs, maybe it's better to keep only one?

nikolay shapovalov’s picture

nikolay shapovalov commented
Issue tags: +Coding standards
nikolay shapovalov’s picture

nikolay shapovalov commented
Issue tags: +Dependency Injection (DI)
nikolay shapovalov’s picture

nikolay shapovalov commented

I made review, but it would be good if somebody else can take a look.
Thanks for your changes.
Are we going to apply changes to 8.x-3.x-dev as well?

idebr made their first commit to this issue’s fork.

roberttabigue’s picture

roberttabigue commented
Status: Needs review » Reviewed & tested by the community

Hi,

I reviewed the results in the GitLab CI pipeline and confirmed that the errors no longer exist.
Here are the links for reference:
PHPCS: https://git.drupalcode.org/issue/simplesamlphp_auth-3401289/-/jobs/8422473
ESLINT: https://git.drupalcode.org/issue/simplesamlphp_auth-3401289/-/jobs/8422474
PHPSTAN: https://git.drupalcode.org/issue/simplesamlphp_auth-3401289/-/jobs/8422475

I'm moving this now to "RTBC".

Thank you!