Problem/Motivation

Hi,
I've started to suggest a few translations on localize.drupal.
I realised that the naming nomenclature for the regions was not the same for the header regions as for the footer regions.

Eg: Header Operator Logo vs Footer - Operator Logo

Proposed resolution

I suggest standardising the naming of the labels by adding a separator (-) in the label of all the regions. This will improve readability and once done, I could suggest translating the regions on localize.

Issue fork ui_suite_dsfr-3401086

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Martygraphie created an issue. See original summary.

Martygraphie opened merge request !49

martygraphie’s picture

martygraphie commented
Status: Active » Needs review
pdureau’s picture

pdureau commented
Status: Needs review » Needs work

Good idea, but we can do better :)

There is a little lack of consistency in your proposition. For example:

  header_operator_logo: Header - Operator Logo
  header_tools_links: Header - Tools links
  header_tools_search: Header - Tools search

"Operator Logo" is title case, but "Tools links" is sentence case.

I am proposing to use the sentence case in both sides of the dash:

Lorem ipsum dolor sit amet - Consectetur adipiscing elit

pdureau’s picture

pdureau commented
Title: Standardize the labels of the theme's regions » [beta6] Standardize the labels of the theme's regions
martygraphie’s picture

martygraphie commented
Status: Needs work » Needs review

Hi Pierre,
Yes, good idea, I've updated my commit,
I'll let you check
Have a nice day

pdureau’s picture

pdureau commented
Assigned: Unassigned » pdureau

ok, i will have alook

pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned
Status: Needs review » Needs work

I can't merge your work because your branch is 9 commits behind 1.0.x. Can you rebase your branch and push again?

  • pdureau committed 583431f9 on 1.0.x authored by Martygraphie 
    Issue #3401086 by martygraphie: Standardize the labels of the theme's...
pdureau’s picture

pdureau commented
Status: Needs work » Fixed

Rebased locally. Merged to 1.0.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.