There are needed tests that check:

  • Users have correct access.
  • Users are able to synchronize.

Issue fork entity_translation_sync-3400170

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

omarlopesino created an issue. See original summary.

omarlopesino opened merge request !1

omarlopesino’s picture

omarlopesino
he/him
commented
  1. Added gitlab ci file so tests are run by gitlab ci.
  2. Corrected all reported static analysis errors.
  3. Added tests to ensure module installation is safe, plus only allowed users can access to the sync page.

Pending:

  1. Add tests to check the full synchronization process.
omarlopesino’s picture

omarlopesino
he/him
commented
Status: Active » Needs work
omarlopesino’s picture

omarlopesino
he/him
commented

Added tests that checks the main functionality, with three use cases:

  • Sunny day: Synchronization works with one language and one field.
  • Variant: Synchronization works with multiple languages and different fields in each language
  • Entity has been synchronized successfully to: English, Italian

The only test pending is the one which asserts configuration can be properly configured from UI,

omarlopesino’s picture

omarlopesino
he/him
commented
Assigned: omarlopesino » Unassigned
Status: Needs work » Needs review

Now there are tests that check the configuration page works well, knowing that it has specific form states to show/hide the fields, plus validations.

Ready to review.

omarlopesino’s picture

omarlopesino
he/him
commented
Status: Needs review » Fixed

Merged on 1.0.x. I will create today a 1.1.0 releasenwith changes from https://www.drupal.org/project/entity_translation_sync/issues/3400859

  • omarlopesino committed f27f210c on 1.0.x 
    Issue #3400170: Do not let fields to be checked when there is no edit...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.