Problem/Motivation

As things go, within hours after #3399123: Upgrade JavaScript dependencies to latest minor/patch releases was committed, cspell released a new major version.

$ yarn outdated
[snipped]
cspell                  7.3.9   7.3.9  8.0.0

Let's get this into 10.2.x.

Steps to reproduce

Proposed resolution

$ yarn add -D cspell
$ yarn spellcheck:make-drupal-dict

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3400071

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !5292

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

Well, that is underwhelming, $ yarn add -D cspell results in no changes in our core/misc/cspell/dictionary.txt.
/shrug

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented 
$ yarn-lock-diff -o yarn.old.lock -n yarn.lock
┌──────────────────────────────┬─────────────────────┬────────────────┐
│ package name                 │ old version(s)      │ new version(s) │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ @cspell/cspell-bundled-dicts │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ @cspell/cspell-json-reporter │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ @cspell/cspell-pipe          │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ @cspell/cspell-resolver      │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ @cspell/cspell-service-bus   │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ @cspell/cspell-types         │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ @cspell/dynamic-import       │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ @cspell/strong-weak-map      │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ cspell-dictionary            │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ cspell-gitignore             │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ cspell-glob                  │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ cspell-grammar               │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ cspell-io                    │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ cspell-lib                   │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ cspell-trie-lib              │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ cspell                       │ 7.3.9               │ 8.0.0          │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ node-fetch                   │ 2.7.0               │ -              │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ webidl-conversions           │ [..., 7.0.0], 3.0.1 │ [...], 7.0.0   │
├──────────────────────────────┼─────────────────────┼────────────────┤
│ whatwg-url                   │ [..., 5.0.0]        │ [...]          │
└──────────────────────────────┴─────────────────────┴────────────────┘
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

All they have done is update all their dependencies, unsure why this warrants a major version bump but anyway there are no other differences between 7.3.9 and 8.0.0 so I'm not surprised this change is minimal for us: https://github.com/streetsidesoftware/cspell/blob/main/CHANGELOG.md

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

The change here is to the lockfile and nothing else, in order to get the RTBC queue down a bit I'm committing this even though I reviewed it as the changes are trivial.

Committed and pushed 5341f1dff6 to 11.x and a2b3ceec72 to 10.2.x. Thanks!

  • longwave committed a2b3ceec on 10.2.x 
    Issue #3400071 by Spokje: Update cspell to latest version (major bump...

  • longwave committed 5341f1df on 11.x 
    Issue #3400071 by Spokje: Update cspell to latest version (major bump)
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.2.x-dev

Spokje closed merge request !5292

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.