Problem/Motivation

See screenshot, taken in Module Builder:

Because the primary action in the dropbutton, 'Save' is considerably shorter than 'Save and generate code', the latter gets truncated.

Steps to reproduce

To reproduce in Module Builder:

  1. Install the module builder.
  2. At admin/config/development/module_builder create a module and save it.
  3. Once the module is saved, the save button shows the problem.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#16 stark.png631.73 KBshweta__sharma
#16 olivero.png1.67 MBshweta__sharma
#16 claro.png570.02 KBshweta__sharma
#9 dropdown-item-after.png61.62 KBlaurielim
#9 dropdown-item-before.png85.02 KBlaurielim
#9 dropdown-item-after--module_builder.png30.13 KBlaurielim
Screenshot 2023-11-07 at 10.17.07.png32.53 KBjoachim

Issue fork drupal-3399804

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Issue tags: +Needs issue summary update

I can't reproduce this bug in the core admin pages for dropbutton / small / extrasmall variants. For those who didn't use Module Builder please describe steps to reproduce

joachim’s picture

joachim commented

> I can't reproduce this bug in the core admin pages for dropbutton / small / extrasmall variants. For those who didn't use Module Builder please describe steps to reproduce

Yes because there are probably no buttons in core with text like that.

It would take longer to create code to reproduce this than it would to simply install Module Builder.

joachim’s picture

joachim commented
Issue summary: View changes
Issue tags: -Needs issue summary update
shweta__sharma’s picture

shweta__sharma commented
Title: Dropbutton items get truncated if they are longer than the button main item's text » Drop-button items get truncated if they are longer than the button main item's text
Issue summary: View changes
shweta__sharma’s picture

shweta__sharma commented
Issue summary: View changes

Laurie Lim made their first commit to this issue’s fork.

Laurie Lim opened merge request !5351

laurielim’s picture

laurielim commented
Status: Active » Needs review
StatusFileSize
new dropdown-item-after--module_builder.png30.13 KB
new dropdown-item-before.png85.02 KB
new dropdown-item-after.png61.62 KB

Updated dropbutton.pcss.css to wrap text inside dropdown item. Module builder is not compatible with 11.x but change can be tested on any other dropdown, e.g: the comments view. See screenshot for both module builder and comments view dropdowns.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs review » Needs work
laurielim’s picture

laurielim commented
Status: Needs work » Needs review

Updated the property, end result is still the same so screenshot still valid.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Needs work

It looks like the MR still has a stylelint violation. You can fix this by running following commands and committing the changes:

cd core
yarn install
yarn run lint:css --fix
laurielim’s picture

laurielim commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Stylelint has been addressed.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Drop-button items get truncated if they are longer than the button main item's text » Dropbutton items get truncated if they are longer than the button main item's text
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs manual testing

We also need to check whether this bug exists in the other core themes. Thanks!

shweta__sharma’s picture

shweta__sharma commented
StatusFileSize
new claro.png570.02 KB
new olivero.png1.67 MB
new stark.png631.73 KB

Hi @xjm,
I have checked the issue in core themes and from my observation, the issue only exists in the claro theme. Below are some screenshots of each theme. Thanks

Claro theme

claro

Stark theme

stark

Olivero theme

olivero

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

per #16

  • ckrina committed e3a964b0 on 11.x 
    Issue #3399804 by Laurie Lim, shweta__sharma, joachim, kostyashupenko,...
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Fixed

Committed e3a964b and pushed to 11.x. Thanks!

saschaeggi’s picture

saschaeggi
he/him
commented
Issue tags: +ClaroContributionDay2023

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.