Hello and thanks for this nice module:)

Problem/Motivation

Do you have plans for LibreTranslate integration?

Best,
Orkut

CommentFileSizeAuthor
#8 3399617.patch11.44 KBjmauricio
#6 3399617.patch5.12 KBjmauricio

Comments

Orkut Murat Yılmaz created an issue. See original summary.

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented

I've also just found the LibreTranslate module. It would be nice to merge the efforts:)

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
Related issues: +#3399619: Merge with Auto Node Translate Project
kallado’s picture

kallado commented

Not really but if you are interessed in helping out you can take a look at how the amazon API was implementede here
https://www.drupal.org/project/auto_node_translate/issues/3322954
We are kind of busy right now and still have some opened issues (bugs) to fix but we can take a look wenever we have some spare minutes.

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented

@kallado, thanks for this beautiful comment:)

I'm waiting for @dcimorra's comment now. If they don't want to do, I'll give it a try on this issue, next month.

jmauricio’s picture

jmauricio commented
Assigned: Unassigned » jmauricio
Status: Active » Needs work
StatusFileSize
new 3399617.patch5.12 KB

@Orkut Murat Yılmaz or anyone else interested.

Can you test this patch, it integrates LibreTranslate into this module.
I've tested with a self-hosted version, works fine.

Thanks

jmauricio’s picture

jmauricio commented
Version: 2.1.7 » 2.1.9
Assigned: jmauricio » Unassigned
Status: Needs work » Needs review
jmauricio’s picture

jmauricio commented
StatusFileSize
new 3399617.patch11.44 KB

The patch didn't include the api file, here's the correct one

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented

@jmauricio thanks for your patch. I've just checked the code and it looks fine. I'm going to test it in a day or two.

kallado’s picture

kallado commented

Tested and it looks fine

  • jmauricio committed 5b7210fe on 1.0.x 
    Issue #3399617 by jmauricio, Orkut Murat Yılmaz, kallado: LibreTranslate...
jmauricio’s picture

jmauricio commented
Status: Needs review » Reviewed & tested by the community
jmauricio’s picture

jmauricio commented
Status: Reviewed & tested by the community » Fixed

https://www.drupal.org/project/auto_node_translate/releases/2.1.10

jmauricio’s picture

jmauricio commented
Status: Fixed » Closed (fixed)
orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented

Thanks for the merge with the stable branch:)

Can you add this one to the module description too?