Add hook_requirements() to check library and print status report

Indeed @maxilein, the library version is an important subject. The new 2.0 module release allows to use the 1.10 datatables library version. See #2999400: [META] Keep track of DataTables library versions. In the installed system it is possible to know the datatables library 1.10 version used using command composer show datatables/datatables. Actually 1.10.21.

@maxilein, actually installing the datatables library with composer is possible but rather not simple.The next step now is to install this library in simple way via composer (See #3415937: The module needs a composer.json file). The means to get the library version with the drush show command would be explained in the README.md file. However, indeed, this version should be reflected in a code file, like .libraries.yml as you suggest in the IS.

Hello,

I'm trying to install the data tables module, however, it doesn't look like the library is installed properly. Every now and again I get the following notice:

Warning: file_get_contents(libraries/datatables/media/js/jquery.dataTables.js): Failed to open stream: No such file or directory in Drupal\Core\Asset\JsOptimizer->optimize() (line 39 of core/lib/Drupal/Core/Asset/JsOptimizer.php).

I have copied the library from vendor to libraries/datatables/datatables as the documentation.

Is there a way to put the library status under "status report"? I only suggest there as webform and other mods put it there.

Edit: I believe the library is installed now as the error isn't showing but still would be good to have a library install status :)

Hi,

I have tested the MR, and it is working fine for me. Here are the steps I followed:

1. Installed the module.
2. Applied the MR.
3. Installed the required libraries as described in the readme file.

After installing the libraries properly, the error message no longer appears on the status report page.

Good finding and good work. +1

I am confused, I have updated datatables, but status report says I am missing assets.

This added a check for the following assets
https://git.drupalcode.org/project/datatables/-/blob/2.x/datatables.modu...

// Check if the essential CSS and JavaScript files exist.
    $essential_assets = [
      'css' => ['jquery.dataTables.css', 'dataTables.bootstrap.css'],
      'js' => ['jquery.dataTables.js', 'dataTables.bootstrap.js'],
    ];

But the libraries.yml only loads the non-bootstrap assets.

datatables_core:
  version: 1.10
  js:
    /libraries/datatables/media/js/jquery.dataTables.js: {}
  css:
    component:
      /libraries/datatables/media/css/jquery.dataTables.css: {}
  dependencies:
    - core/jquery

So how are we supposed to load the dataTables.bootstrap.css dataTables.bootstrap.js assets? There is nothing in the readme about that. It seems like those should be removed from the status page check for correct assets, some projects don't use bootstrap.

Looks like the path to check for assets is incorrect, composer does not place the datatables library in a subfolder called datatables.

Should just be libraries/datatables/* not libraries/datatables/datatables/*

I'll create a new issue about this.