wxt_core hook updates contain deprecated API calls.
There are some cases where we may want to re-run a previous update hook in D10, and just also to be consistent , let's replace all the deprecated api references.
See patch
drush eval "\Drupal::service('update.update_hook_registry')->setInstalledVersion('wxt_core', 8432);";
drush updb;See patch
Review, test and commit patch
N/A
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | issue-3399083-after.png | 96.88 KB | danrod |
| #10 | issue-3399083-before.png | 80.67 KB | danrod |
| #4 | D10-compatible_hook_updates-3399083-04.patch | 7.97 KB | joseph.olstad |
Comments
Comment #2
joseph.olstadComment #3
joseph.olstadReviewing and testing patch #2, I'll adjust it if needed.
Comment #4
joseph.olstadOoops, go with patch #4 instead
Comment #5
joseph.olstadReviewing patch #4 now
Comment #6
joseph.olstadPatch #4 appears to work
Comment #7
joseph.olstadRTBC my own patch, just saying that I tested patch #4 to work, if you disagree, test it yourself.
Comment #8
joseph.olstadComment #9
joseph.olstadpatch 4 is good to go.
These hook updates could still be helpful in D10 in case someone still lingers along with lightning_ junk and later needs to clean it would want to re-run 8433.
Comment #10
danrodI tested patch #4 and works as expected, attached screenshots of running the drush commands before and after the patch.
Comment #11
joseph.olstadFully reviewed as per @danrod
Thanks :)
Comment #12
sylus commentedCommitted and attributed!
Thanks so much for fixing this!