Problem/Motivation

During the migration to GitlabCI detected new PHPCS warnings.

https://git.drupalcode.org/project/layout_builder_lock/-/jobs/263174

Issue fork layout_builder_lock-3398496

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Panchuk created an issue. See original summary.

chetan 11’s picture

chetan 11 commented
Assigned: Unassigned » chetan 11

chetan 11 opened merge request !16

chetan 11’s picture

chetan 11 commented
Assigned: chetan 11 » Unassigned
Status: Active » Needs review

Hi Panchuk
I have fixed all the phpcs issues in "Layout Builder Lock" module.
please check the raised MR.
Thanks

panchuk’s picture

panchuk
Location Texas, USA
commented
Status: Needs review » Needs work

Hey @chatan-11

Thanks for your contribution! I reviewed MR and found a few problems.

PHPCS still failed in the layout_builder_lock.module file.
https://git.drupalcode.org/issue/layout_builder_lock-3398496/-/jobs/264738

| Hook implementations should not duplicate @param
| documentation
| (Drupal.Commenting.HookComment.HookParamDoc)

These errors mean that the doc for hooks shouldn't contain any @param or @return props.

Example:

/**
* Implements hook_element_info_alter().
*/

chetan 11’s picture

chetan 11 commented
Status: Needs work » Needs review
clarkssquared’s picture

clarkssquared commented
Status: Needs review » Reviewed & tested by the community

Hi chetan,

I applied your updated MR !16 into my local and as I execute the PHPCS command its now flagged no PHPCS issues in the module

➜  layout_builder_lock git:(4e0e049) curl https://git.drupalcode.org/project/layout_builder_lock/-/merge_requests/16.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 27084    0 27084    0     0  49795      0 --:--:-- --:--:-- --:--:-- 51984
patching file README.md
patching file 'js/layout-builder-lock.admin.js'
patching file layout_builder_lock.module
patching file 'src/Access/LayoutBuilderLockAccessCheck.php'
patching file 'src/LayoutBuilderLock.php'
patching file 'tests/src/Functional/LayoutBuilderLockTest.php'
➜  layout_builder_lock git:(4e0e049) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml layout_builder_lock
                                                                                
➜  contrib git:(master) ✗
chetan 11’s picture

chetan 11 commented

I have changed all the things as per the mention in comments.

  • Panchuk committed 75a5257f on 8.x-1.x authored by chetan 11 
    Issue #3398496 by chetan 11, Panchuk, clarkssquared: Fix PHPCS warnings
panchuk’s picture

panchuk
Location Texas, USA
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.