Problem/Motivation

In ConfigEntityType.php:

  /**
   * {@inheritdoc}
   */
  public function getBaseTable() {
    return FALSE;
  }

  /**
   * {@inheritdoc}
   */
  public function getRevisionDataTable() {
    return FALSE;
  }

  /**
   * {@inheritdoc}
   */
  public function getRevisionTable() {
    return FALSE;
  }

  /**
   * {@inheritdoc}
   */
  public function getDataTable() {
    return FALSE;
  }

Whereas in EntityTypeInterface, each function says:

   * @return string|null
   *   The name of the entity type's revision table, or NULL if none exists.

Proposed resolution

Return NULL instead, or update the phpdoc comments.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3398090

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

solideogloria created an issue. See original summary.

solideogloria’s picture

Issue summary: View changes

viren18febS made their first commit to this issue’s fork.

viren18febs’s picture

Status: Active » Needs review

Hi solideogloria,

I have update the return values as per proposed resolution & created MR, please review.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Issue probably should of been tagged novice for new users.

If we had typehint on EntityTypeInterface this probably wouldn't happen but change seems fine.

longwave’s picture

Status: Reviewed & tested by the community » Fixed

Given this is a very minor behaviour change but otherwise doesn't apparently affect anything, committing to 11.x only just in case someone was relying on the exact type in 10.2 somehow.

Committed f3c999f and pushed to 11.x. Thanks!

  • longwave committed f3c999ff on 11.x
    Issue #3398090 by viren18febS, solideogloria: ConfigEntityType inherited...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.