Problem/Motivation
In ConfigEntityType.php:
/**
* {@inheritdoc}
*/
public function getBaseTable() {
return FALSE;
}
/**
* {@inheritdoc}
*/
public function getRevisionDataTable() {
return FALSE;
}
/**
* {@inheritdoc}
*/
public function getRevisionTable() {
return FALSE;
}
/**
* {@inheritdoc}
*/
public function getDataTable() {
return FALSE;
}
Whereas in EntityTypeInterface, each function says:
* @return string|null
* The name of the entity type's revision table, or NULL if none exists.
Proposed resolution
Return NULL instead, or update the phpdoc comments.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comments
Comment #2
solideogloria commentedComment #5
viren18febs commentedHi solideogloria,
I have update the return values as per proposed resolution & created MR, please review.
Comment #6
smustgrave commentedIssue probably should of been tagged novice for new users.
If we had typehint on EntityTypeInterface this probably wouldn't happen but change seems fine.
Comment #7
longwaveGiven this is a very minor behaviour change but otherwise doesn't apparently affect anything, committing to 11.x only just in case someone was relying on the exact type in 10.2 somehow.
Committed f3c999f and pushed to 11.x. Thanks!