Problem/Motivation

Added in 2012, last/only usage was removed in 2020.

This needs to be deprecated (see https://www.drupal.org/about/core/policies/core-change-policies/drupal-d...) for removal in 11.0.x. No deprecation test necessary since we're just deprecating unused code with no complex bc layer or anything.

Tagging novice since it should hopefully be straightforward.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3397488

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

nbeaucage’s picture

I'll be working on this.

nbeaucage’s picture

Status: Active » Needs review

I had to be specific with the versions for the @deprecated statement, so I looked for the last/only usage removal of CacheDecoratorInterface in 2020, which seemed to be pointing to the 9.0.0 version of Drupal core.

I found this commit: Issue #3092090 by Berdir, Wim Leers, plach, amateescu: Remove legacy Path Alias subsystem, and then this issue: Remove legacy Path Alias subsystem, which was Closed (fixed) for the 9.0.x-dev version of Drupal core.

Please feel free to have me update the @deprecated statement as needed if it seems incorrect.

smustgrave’s picture

Status: Needs review » Needs work

So depends when this gets committed. But 9.0 has passed.

Could be deprecated in 10.2 and removed in D11.

But will need it's own change record and the link in the comment should point to that CR. Example https://www.drupal.org/node/3387830

nbeaucage’s picture

Assigned: Unassigned » nbeaucage
Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Thanks! Think this is good.

nbeaucage’s picture

Assigned: nbeaucage » Unassigned

@smustgrave Thank you for the feedback!

I have one question regarding the Change record being in a draft state: when should it be published (by me or anyone else)? Once this issue's MR is merged? I'm new to the Change record process, so I'm wondering what to do about that.

Thanks for your time!

smustgrave’s picture

When the committer merges the code they will publish the CR for ya. So essentially for this one would just keep an eye out if any additional feedback comes through or is sent back for whatever reason.

nbeaucage’s picture

Got it, thanks!

kristiaanvandeneynde’s picture

Change record looks good, reasoning is also sound. +1

longwave made their first commit to this issue’s fork.

longwave’s picture

Changed the wording to the common wording we use when there is no replacement; the deprecation message tells you what to do (in this case, you are on your own) and the change record tells you why.

longwave’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 4cff7cd61d to 11.x and c31491b7c3 to 10.2.x. Thanks!

Also published the change record.

  • longwave committed c31491b7 on 10.2.x
    Issue #3397488 by nbeaucage, longwave, smustgrave, catch: Deprecate...

  • longwave committed 4cff7cd6 on 11.x
    Issue #3397488 by nbeaucage, longwave, smustgrave, catch: Deprecate...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.