Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
cache system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Oct 2023 at 07:22 UTC
Updated:
21 Nov 2023 at 21:14 UTC
Jump to comment: Most recent
Comments
Comment #2
nbeaucage commentedI'll be working on this.
Comment #4
nbeaucage commentedI had to be specific with the versions for the
@deprecatedstatement, so I looked for the last/only usage removal ofCacheDecoratorInterfacein 2020, which seemed to be pointing to the9.0.0version of Drupal core.I found this commit: Issue #3092090 by Berdir, Wim Leers, plach, amateescu: Remove legacy Path Alias subsystem, and then this issue: Remove legacy Path Alias subsystem, which was Closed (fixed) for the 9.0.x-dev version of Drupal core.
Please feel free to have me update the
@deprecatedstatement as needed if it seems incorrect.Comment #5
smustgrave commentedSo depends when this gets committed. But 9.0 has passed.
Could be deprecated in 10.2 and removed in D11.
But will need it's own change record and the link in the comment should point to that CR. Example https://www.drupal.org/node/3387830
Comment #6
nbeaucage commented@deprecated in drupal:10.2.0 and is removed from drupal:11.0.0.Comment #7
smustgrave commentedThanks! Think this is good.
Comment #8
nbeaucage commented@smustgrave Thank you for the feedback!
I have one question regarding the Change record being in a draft state: when should it be published (by me or anyone else)? Once this issue's MR is merged? I'm new to the Change record process, so I'm wondering what to do about that.
Thanks for your time!
Comment #9
smustgrave commentedWhen the committer merges the code they will publish the CR for ya. So essentially for this one would just keep an eye out if any additional feedback comes through or is sent back for whatever reason.
Comment #10
nbeaucage commentedGot it, thanks!
Comment #11
kristiaanvandeneyndeChange record looks good, reasoning is also sound. +1
Comment #13
longwaveChanged the wording to the common wording we use when there is no replacement; the deprecation message tells you what to do (in this case, you are on your own) and the change record tells you why.
Comment #14
longwaveCommitted and pushed 4cff7cd61d to 11.x and c31491b7c3 to 10.2.x. Thanks!
Also published the change record.