In #3252386: Use PHP attributes instead of doctrine annotations we switched to parsing annotations before attributes. This is not great for performance when core is converted.
At some point in the future, potentially around the time 11.0.0 is released, most contrib will also be converted, and then it'll be even worse for performance.
Opening to see if we can switch the order back again, for example in 10.4.0 or 10.5.0
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !11957
Comments
Comment #2
claudiu.cristeaPostponed on #3502913: Add a fallback classloader that can handle missing traits for attribute discovery
Comment #3
godotislate#3502913: Add a fallback classloader that can handle missing traits for attribute discovery is in, so this is unblocked.
Comment #5
godotislateMR is ready https://git.drupalcode.org/project/drupal/-/merge_requests/11957
Comment #6
claudiu.cristeaDo we need a test to prove it?
Comment #7
godotislateWasn't sure tests were necessary, but it was relatively low lift, so added them.
Comment #8
claudiu.cristeaGreat. I was looking to the MR and everything looks good. I think we still miss a CR because some sites might rely on annotations precedence. I know, very unlikely, but let's add a record to announce this change.
Comment #9
godotislateCR https://www.drupal.org/node/3521588
Comment #10
claudiu.cristeaThank you. This looks and works as expected
Comment #11
catchYeah agreed with the CR, seems possible that an incorrect attribute that was being ignored would start to cause problems.
I nearly went to commit this, but I think there is one comment in the test where annotation and attribute are reversed. If that's the issue, please feel free to self-RTBC after fixing it. I theoretically could have changed it on commit but would rather get confirmation that's just a typo and not anything else.
Comment #12
godotislateReplied in MR, but comment looks correct to me. The plugin manager in that test case only looks at annotations, so for the plugin that has both, the annotation gets picked up. If that's unclear, I'm open to changes.
Comment #13
catchohhh I see. OK back to RTBC, thanks for clarifying.
Comment #15
catchCommitted/pushed to 11.x, thanks!
Comment #17
claudiu.cristeaPublished the CR