Problem/Motivation

We have introduced PHPCS checks in the D7 GitlabCI, but it seems like that we cannot use allow_failure: false, because this can block our ability to run regular test jobs in case the modified file has some issues already.

See this MR, which is OK: https://git.drupalcode.org/project/drupal/-/merge_requests/5113/diffs , but the file itself has deprecations in PHP 5.6, so it will fail the PHPCS job:

https://git.drupalcode.org/project/drupal/-/merge_requests/5113/pipelines
https://git.drupalcode.org/issue/drupal-3396440/-/jobs/219741

Steps to reproduce

See: https://git.drupalcode.org/project/drupal/-/merge_requests/5113/pipelines

Proposed resolution

Set allow_failure: true in PHPCS Lint job, since there seems to be no other way around it.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3397119

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

poker10 created an issue. See original summary.

poker10’s picture

poker10 commented
Parent issue: #3397117: SQLite testing in GitlabCI - apache2(98)Address already in use »

fjgarlin made their first commit to this issue’s fork.

fjgarlin opened merge request !5151

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review

I made the suggested changes. MR is ready for review.
This will allow the tests to run even if there are warnings in the phpcs job.

bhanu951’s picture

bhanu951 commented

Considering we already use it in 11.x and it works as expected .

+1 for RTBC from me.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me! Small but important change 😉

  • poker10 committed 7552f8ba on 7.x 
    Issue #3397119 by fjgarlin: Allow failures in D7 GitlabCI PHPCS checks
poker10’s picture

poker10 commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks everyone!

poker10 closed merge request !5151

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.