Problem/Motivation

Deprecated function: Creation of dynamic property Drupal\webform_views\Plugin\views\relationship\WebformViewsEntityReverse::$joinManager is deprecated in Drupal\webform_views\Plugin\views\relationship\WebformViewsEntityReverse->__construct() (line 32 of modules/contrib/webform_views/src/Plugin/views/relationship/WebformViewsEntityReverse.php).

The same class also uses $this->first_alias without declaring that member variable.

Steps to reproduce

Upgrade to Drupal 10.1.

Proposed resolution

Declare the member variables.

  protected ViewsHandlerManager $joinManager;
  protected string $first_alias;
CommentFileSizeAuthor
#6 webform_views-3396671-3.patch591 bytessolideogloria

Issue fork webform_views-3396671

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

solideogloria created an issue. See original summary.

solideogloria’s picture

solideogloria commented
Issue summary: View changes

solideogloria opened merge request !16

solideogloria’s picture

solideogloria commented

Technically, member variables should be lowerCamelCase, not snake_case, but that might break BC.

solideogloria’s picture

solideogloria commented
Status: Active » Needs review
solideogloria’s picture

solideogloria commented
StatusFileSize
new webform_views-3396671-3.patch591 bytes

Patch file for ease of use.

philiph91’s picture

philiph91 commented

Hi,

I've tested the proposed solution and we have no more errors.

FYI: this is really annoying, Drupal shows these warnings to ALL users :-/

Thanks for the patch!

solideogloria’s picture

solideogloria commented
Status: Needs review » Reviewed & tested by the community
dropa’s picture

dropa commented

Can confirm RTBC.

@philiph91

FYI: this is really annoying, Drupal shows these warnings to ALL users :-/

Drupal, in fact by default doesn't do that. You might want to check that you don't have developer settings turned on where you don't want them. Here's couple handy links for you

https://www.drupal.org/docs/develop/development-tools/enable-verbose-err...

https://www.php.net/manual/en/function.error-reporting.php

VladimirAus made their first commit to this issue’s fork.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Thanks, everyone! Commited! 🥃

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.