The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
Discovered whilst working on #3393170: [random test failure] in GenerateThemeTest::testGeneratingFromAnotherThem
In \Drupal\BuildTests\Framework\BuildTestBase::getCodebaseFinder we don't exclude the node dependencies from being copied.
Steps to reproduce
Proposed resolution
Exclude directory core/node_modules in \Drupal\BuildTests\Framework\BuildTestBase::getCodebaseFinder.
It's not needed, cause slowness and disk-space issues when used in a repeated run test.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3396574
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3396574-exclude-copying-corenodemodules
changes, plain diff MR !5122
Comments
Comment #3
spokjeComment #4
smustgrave commentedWon't pretend I know know that system but the idea of excluding node_modules makes sense.
Comment #5
catchYes this just looks like an oversight.
I started wondering whether we should try to use (or find a way to add a common default for)
$settings['file_scan_ignore_directories']but then persuaded myself that just hardcoding this here is fine.Committed/pushed to 11.x, cherry-picked to 10.2.x and 10.1.x, thanks!
Comment #9
catch