Problem/Motivation

We are experiencing multiple deprecation warnings on PHP 8.1 in the decode_entities() function:

Deprecated function: html_entity_decode(): Passing null to parameter #1 ($string) of type string is deprecated in decode_entities() (line 463 of includes/unicode.inc).

I'm posting this as prior art #3270881: [D7 PHP 8.1] strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in text_summary(). I've been posting issues on the originating modules to solve this but it's coming from the same source in core.

Steps to reproduce

Proposed resolution

Cast the input as a string.

Issue fork drupal-3396440

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joelpittet created an issue. See original summary.

joelpittet opened merge request !5113

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review

poker10 made their first commit to this issue’s fork.

tibezh’s picture

tibezh commented
Status: Needs review » Reviewed & tested by the community

Looks good.
The patch covers really important things to support PHP 8.1 on D7.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Parent issue: #3224299: [META] Make Drupal 7 core compatible with PHP 8.1 » #3366270: [meta] Priorities for 2023-12-06 release of Drupal 7
Related issues: +#3224299: [META] Make Drupal 7 core compatible with PHP 8.1
poker10’s picture

poker10 commented
Issue tags: +Pending Drupal 7 commit
Parent issue: #3366270: [meta] Priorities for 2023-12-06 release of Drupal 7 » #3224299: [META] Make Drupal 7 core compatible with PHP 8.1
Related issues: -#3224299: [META] Make Drupal 7 core compatible with PHP 8.1

I think this looks good. This code

var_dump(html_entity_decode(NULL, ENT_QUOTES, 'UTF-8'));

in PHP 8.3, 8.2, 8.1 results in:

Deprecated: html_entity_decode(): Passing null to parameter #1 ($string) of type string is deprecated
string(0) ""

and in PHP 7.4, 7.3 and lower in:

string(0) ""

So by casting to string we will keep the same behavior of this function - an empty string will be returned without a deprecation message.

I have added a NULL value to the existing tests. Seems like all pipelines are green (https://git.drupalcode.org/project/drupal/-/pipelines/59079), so adding a tag for the final review. Here is a test-only test which failed as expected: https://git.drupalcode.org/project/drupal/-/jobs/434910. Thanks.

fabianx’s picture

fabianx commented

RTBC

  • mcdruid committed 68ca415f on 7.x 
    Issue #3396440 by poker10, joelpittet, tibezh, Fabianx: [D7 PHP 8.1]...
mcdruid’s picture

mcdruid commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

Thanks everybody!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nicxvan closed merge request !5113