Clarify event labels with grouping on email configuration form [#3395997]

Problem

The "Event" dropdown field on "Add email" page having options referred from all of the workflow providers available in the system. this leads ambiguity when events from multiple workflows for same groups are loaded as dropdown options.

Steps to reproduce

Observe options of field "Event" on admin/commerce/config/emails/add

Proposed resolution

We should modify it to be more informative just like the "Add a new field" have option-groups on any content-type's Manage fields page. This improvement will help administrators to select the appropriate events for the Email.

Comment	File	Size	Author
#8	interdiff_6_8.txt	992 bytes	khiminrm
#8	the-event-field-options-are-ambiguous-3395997-8.patch	3.15 KB	khiminrm
#6	the-event-field-options-are-ambiguous-3395997-6.patch	3.05 KB	vipin.j
#5	Screenshot 2024-02-02 at 8.04.42 AM.png	82.63 KB	morbus iff
#3	the-event-field-options-are-ambiguous-3395997-3.patch	3.22 KB	vipin.j
#2	the-event-field-options-are-ambiguous-3395997-2.patch	2.36 KB	vipin.j

Issue fork commerce_email-3395997

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3395997-the-event-field changes, plain diff MR !29
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

23 October 2023 at 07:41

vipin.j created an issue. See original summary.

Comment #2

vipin.j commented 23 October 2023 at 07:55

Status:

Active

» Needs review

Status	File	Size
new	the-event-field-options-are-ambiguous-3395997-2.patch	2.36 KB

Here is the patch for the requirement of this issue, hopefully it will help.

Comment #3

vipin.j commented 30 October 2023 at 16:11

Status	File	Size
new	the-event-field-options-are-ambiguous-3395997-3.patch	3.22 KB

The patch #2 re-rolled with improvements.

Comment #4

vmarchuk

English

Rivne, UA

commented 2 February 2024 at 07:10

I think it makes more sense to group by entity_type taken from the plugin annotations, but since we currently have no more than 10 options, that doesn't make sense. Thoughts?