Problem/Motivation

Following dependency evaluations for both components, add both packages into core.

Issue fork drupal-3395586

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andy-blum created an issue. See original summary.

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented
Issue summary: View changes

andy-blum opened merge request !5067

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Category: Feature request » Task
Status: Active » Needs work

Looks good except for one out of scope change to the root composer.json.

deviantintegral made their first commit to this issue’s fork.

deviantintegral’s picture

deviantintegral commented

I think the nightwatch failures are unrelated to these changes. In the Nightwatch job at Tests/Olivero/oliveroColorTest.js:

unhandledRejection: stale element reference: element is not attached to    ││   the page document
deviantintegral’s picture

deviantintegral commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Believe it needs a manual rebase. Says it's unmergable .

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented
Status: Needs work » Needs review
deviantintegral’s picture

deviantintegral commented
Status: Needs review » Reviewed & tested by the community

Latest reroll looks good to me.

alexpott credited catch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Discussed at length at Drupalcon with @catch we agreed to add these as full runtime dependencies to make generating themes simpler and because they are there if you require Drush.

Committed 7f540d8 and pushed to 11.x. Thanks!

leaving open for backport to 10.2.x

  • alexpott committed 7f540d89 on 11.x 
    Issue #3395586 by andy-blum, deviantintegral, longwave, catch: Add...

  • alexpott committed 60367575 on 10.2.x 
    Issue #3395586 by andy-blum, deviantintegral, longwave, catch: Add...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Patch (to be ported) » Fixed

Discussed with @catch and we agreed to backport.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.