Problem/Motivation

When you run cron you should see the following error:

Warning: Trying to access array offset on value of type null in Drupal\Core\Cron->processQueue() (line 264 of /var/www/html/core/lib/Drupal/Core/Cron.php)

Steps to reproduce

Run cron.

Proposed resolution

  1. Take into account that the parent class has a constructor.
  2. Since the class code of both plugins is completely the same, create a base class for them.
  3. Ensure that the user entity is found based on E-mail and that the user entity isn't a pre-defined entity created during the enabling installation profile.
CommentFileSizeAuthor
#5 interdiff_4-5.txt741 bytesohorbatiuk
#5 exception-mailer-queue-worker-3395572-5.patch8.64 KBohorbatiuk
#4 interdiff_3-4.txt706 bytesohorbatiuk
#4 exception-mailer-queue-worker-3395572-4.patch8.64 KBohorbatiuk
#3 interdiff_2-3.txt3.83 KBohorbatiuk
#3 exception-mailer-queue-worker-3395572-3.patch7.95 KBohorbatiuk
#2 exception-mailer-queue-worker-parent-3395572-2.patch4.87 KBohorbatiuk

Issue fork exception_mailer-3395572

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lexhouk created an issue. See original summary.

ohorbatiuk’s picture

ohorbatiuk
he/him/his
Primary language Ukrainian
Location Ukraine 🇺🇦
commented
Assigned: ohorbatiuk » Unassigned
Status: Active » Needs review
StatusFileSize
new exception-mailer-queue-worker-parent-3395572-2.patch4.87 KB
ohorbatiuk’s picture

ohorbatiuk
he/him/his
Primary language Ukrainian
Location Ukraine 🇺🇦
commented
Issue summary: View changes
StatusFileSize
new exception-mailer-queue-worker-3395572-3.patch7.95 KB
new interdiff_2-3.txt3.83 KB

Ensure that the user entity is found based on E-mail and that the user entity isn't a pre-defined entity created during the enabling installation profile.

ohorbatiuk’s picture

ohorbatiuk
he/him/his
Primary language Ukrainian
Location Ukraine 🇺🇦
commented
StatusFileSize
new exception-mailer-queue-worker-3395572-4.patch8.64 KB
new interdiff_3-4.txt706 bytes

Add checking to exist a severity record during letter content creation.

ohorbatiuk’s picture

ohorbatiuk
he/him/his
Primary language Ukrainian
Location Ukraine 🇺🇦
commented
StatusFileSize
new exception-mailer-queue-worker-3395572-5.patch8.64 KB
new interdiff_4-5.txt741 bytes

Fix the condition that was added in the previous patch.

szato’s picture

szato commented
Version: 4.0.0 » 4.0.x-dev
Status: Needs review » Needs work
Related issues: +#3405521: Undefined array key "severity" in exception_mailer_mail()

@lexhouk,

thank you for your report, and work.

We should update the patch:

szato’s picture

szato commented

We also want to send emails to addresses that aren't associated with existing users, so we need something like this:

  $data['email'] = $admin;
  if ($user = user_load_by_mail($admin)) {
    $data['user_langcode'] = $user->getPreferredLangcode();
  }
  $queue->createItem($data);
}
szato’s picture

szato commented
Related issues: +#3406304: Error: Call to a member function getPreferredLangcode() on bool

szato opened merge request !4

szato’s picture

szato commented
Status: Needs work » Needs review

Regarding points: 1, 2
I removed 'exception_email_queue' plugin, we are using only the 'manual_exception_email'. Duplicates were made in the commit: https://git.drupalcode.org/project/exception_mailer/-/commit/31379083fbc...

MR created.

Kosa Ilma made their first commit to this issue’s fork.

kosa ilma’s picture

kosa ilma commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.